Truncated-Normal Operation #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Jun 12, 2021
| @@ -156,7 +158,20 @@ public NDArray randomNormal(float loc, float scale, Shape shape, DataType dataTy | |||
| /** {@inheritDoc} */ | |||
| @Override | |||
| public NDArray truncatedNormal(float loc, float scale, Shape shape, DataType dataType) { | |||
| throw new UnsupportedOperationException("Not supported!"); | |||
| Random random = new Random(); | |||
frankfliu
reviewed
Jun 12, 2021
| @@ -13,11 +13,13 @@ | |||
| package ai.djl.ndarray; | |||
|
|
|||
| import ai.djl.Device; | |||
| import ai.djl.ndarray.internal.NDArrayEx; | |||
Codecov Report
@@ Coverage Diff @@
## master #1015 +/- ##
============================================
+ Coverage 69.97% 70.03% +0.06%
- Complexity 5106 5111 +5
============================================
Files 504 504
Lines 22601 22616 +15
Branches 2367 2369 +2
============================================
+ Hits 15815 15840 +25
+ Misses 5519 5513 -6
+ Partials 1267 1263 -4
Continue to review full report at Codecov.
|
frankfliu
approved these changes
Jun 12, 2021
zachgk
reviewed
Jun 14, 2021
| dist[i] = sample; | ||
| } | ||
|
|
||
| return create(dist).addi(loc).muli(scale).reshape(shape).toType(dataType, false); |
There was a problem hiding this comment.
@AzizZayed I think you need to multiply before you add. Otherwise, it will scale the addition too.
AzizZayed
added a commit
to AzizZayed/djl
that referenced
this pull request
Jun 14, 2021
Truncated-Normal Operation Truncated-Normal Operation (deepjavalibrary#1015) * [tensoflow] Add truncated normal operation * Add truncated-normal to all engines that do not support it * Truncated-Normal Operation
frankfliu
pushed a commit
that referenced
this pull request
Jun 15, 2021
* [tensoflow] Add truncated normal operation * Add truncated-normal to all engines that do not support it Truncated-Normal Operation Truncated-Normal Operation (#1015) * [tensoflow] Add truncated normal operation * Add truncated-normal to all engines that do not support it * Truncated-Normal Operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The same as #1005 but for other engines.