Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for truncated-normal #1022

Merged
merged 5 commits into from
Jun 15, 2021
Merged

Conversation

AzizZayed
Copy link
Contributor

@AzizZayed AzizZayed commented Jun 14, 2021

Description

Fix bug where I add the mean before multiplying by the standard deviation when computing the truncated-normal operation.

AzizZayed and others added 4 commits June 9, 2021 15:06
Truncated-Normal Operation

Truncated-Normal Operation (deepjavalibrary#1015)

* [tensoflow] Add truncated normal operation

* Add truncated-normal to all engines that do not support it

* Truncated-Normal Operation
@zachgk
Copy link
Contributor

zachgk commented Jun 14, 2021

@AzizZayed Can you rebase this on top of master?

@frankfliu
Copy link
Contributor

@AzizZayed Please rebase your code

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2021

Codecov Report

Merging #1022 (6e44967) into master (fd84636) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1022   +/-   ##
=========================================
  Coverage     70.00%   70.00%           
  Complexity     5109     5109           
=========================================
  Files           504      504           
  Lines         22617    22617           
  Branches       2372     2372           
=========================================
+ Hits          15833    15834    +1     
+ Misses         5517     5515    -2     
- Partials       1267     1268    +1     
Impacted Files Coverage Δ
...pi/src/main/java/ai/djl/ndarray/BaseNDManager.java 50.00% <0.00%> (ø)
api/src/main/java/ai/djl/repository/Artifact.java 91.37% <0.00%> (-1.73%) ⬇️
api/src/main/java/ai/djl/inference/Predictor.java 90.38% <0.00%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd84636...6e44967. Read the comment docs.

@frankfliu frankfliu merged commit ae86aac into deepjavalibrary:master Jun 15, 2021
@AzizZayed AzizZayed deleted the tnormal branch June 18, 2021 00:33
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants