-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve robustness of get_task HF pipeline invocations #5284
Conversation
Pull Request Test Coverage Report for Build 5476358114
💛 - Coveralls |
All makes sense to me, except 1s timeout seems too aggressive. I'd set it to 2-3 sec. @anakin87 |
@MichelBartels you'll likely need to rebase to main (or merge main) as #5285 fixed the test issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichelBartels, it seems like a nice hotfix to me!
I left two minor comments to improve things...
Nice work 🚀 |
Related Issues
Proposed Changes:
Before this fix, the HF invocation layer was tested early which caused the process not to reach the correct invocation layer check if the HF servers were unresponsive. This PR changes the invocation order so HF is checked later and adds a timeout of 1s so it can't get stuck waiting for a response from the HF servers.
How did you test it?
I added a unit test that checks that the timeout is handled correctly. There is also a new test checking that the huggingface checks are in the last five invocation layer checks.
Notes for the reviewer
The timeout is set to 1s and can't be changed by the user. This could potentially lead to issues. I am also not sure about whether the test for the invocation layer order should be different because it does not make sure the methods are actually called in that order.
I have discussed these changes with @vblagoje who also created the original issue. I am not sure if it might make sense for him to review the PR.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.