Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Remove caching of requests to
huggingface.co
when running tests to integration tests failures.huggingface_hub
already handles caching by itself as documented so this shouldn't affect our limits.How did you test it?
I ran CI with PR #5282 to troubleshoot the issue, turns out that removing cache makes tests run correctly.
Notes for the reviewer
The failures weren't reproducible locally while running individual tests.
Failures examples: https://github.com/deepset-ai/haystack/actions/runs/5473396123
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.