Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move tests for count_documents from DocumentStoreBaseTests to separate class #6332

Merged
merged 1 commit into from
Nov 17, 2023
Merged

refactor: Move tests for count_documents from DocumentStoreBaseTests to separate class #6332

merged 1 commit into from
Nov 17, 2023

Conversation

silvanocerza
Copy link
Contributor

Related Issues

Relates to #6284

Proposed Changes:

Move count_documents tests from DocumentStoreBaseTests into CountDocumentsTest class.

DocumentStoreBaseTests now inherits CountDocumentsTest.

How did you test it?

I ran tests locally.

Notes for the reviewer

Depends on #6324.

This is part of a series of PRs to split tests into different classes. I'll add release notes at the end.

Checklist

@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Nov 17, 2023
@silvanocerza silvanocerza self-assigned this Nov 17, 2023
@silvanocerza silvanocerza requested a review from a team as a code owner November 17, 2023 15:52
@silvanocerza silvanocerza requested review from julian-risch and removed request for a team November 17, 2023 15:52
@github-actions github-actions bot added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Nov 17, 2023
Base automatically changed from tests-document-comparison to main November 17, 2023 16:03
@silvanocerza silvanocerza requested a review from a team as a code owner November 17, 2023 16:03
@silvanocerza silvanocerza mentioned this pull request Nov 17, 2023
Merged
@silvanocerza silvanocerza requested review from masci and removed request for julian-risch November 17, 2023 16:53
masci
masci approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@silvanocerza silvanocerza merged commit 326f51d into main Nov 17, 2023
20 checks passed
@silvanocerza silvanocerza deleted the move-count-documents-tests branch November 17, 2023 17:00
vblagoje pushed a commit that referenced this pull request Nov 22, 2023
@silvanocerza @vblagoje
Move tests for count_document from DocumentStoreBaseTests to separate…
450987d 
… class (#6332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees

@silvanocerza silvanocerza

Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @masci