refactor: Move tests for write_documents from DocumentStoreBaseTests to separate class
#6334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
added
the
ignore-for-release-notes
silvanocerza
requested review from
vblagoje and
masci
and removed request for
a team and
vblagoje
github-actions
bot
added
2.x
masci
reviewed
Nov 17, 2023
| with pytest.raises(ValueError): | ||
| docstore.write_documents("not a list actually") # type: ignore | ||
|
|
||
|
|
||
| class DocumentStoreBaseTests(CountDocumentsTest): |
There was a problem hiding this comment.
This is different from the PR description
There was a problem hiding this comment.
I pushed a fix a the same identical time you commented. 😅
silvanocerza
force-pushed
the
move-write-documents-tests
branch
from
b558049
to
531ebbb
Compare
masci
approved these changes
Nov 17, 2023
silvanocerza
force-pushed
the
move-write-documents-tests
branch
from
531ebbb
to
e67b7e2
Compare
vblagoje
pushed a commit
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Relates to #6284
Proposed Changes:
Move
write_documentstests fromDocumentStoreBaseTestsintoWriteDocumentsTestclass.DocumentStoreBaseTestsnow inheritsWriteDocumentsTest.How did you test it?
I ran tests locally.
Notes for the reviewer
Depends on #6332.
This is part of a series of PRs to split tests into different classes. I'll add release notes at the end.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.