refactor: Move generic filter_documents tests from DocumentStoreBaseTests to separate class
#6338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
added
the
ignore-for-release-notes
silvanocerza
requested review from
a team and
anakin87
and removed request for
a team
github-actions
bot
added
2.x
anakin87
reviewed
Nov 17, 2023
silvanocerza
force-pushed
the
move-generic-filter-documents-tests
branch
from
f5f9de5
to
868ea01
Compare
masci
approved these changes
Nov 17, 2023
silvanocerza
force-pushed
the
move-filterable-docs-fixture
branch
from
8a391ef
to
9f064ac
Compare
silvanocerza
force-pushed
the
move-generic-filter-documents-tests
branch
from
868ea01
to
963eb0e
Compare
…cumentStoreBaseTests` to separate class (#6339) * Move filter_documents tests with invalid filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with equal filters from `DocumentStoreBaseTests` to separate class (#6340) * Move filter_documents tests with equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with not equal filters from `DocumentStoreBaseTests` to separate class (#6341) * Move filter_documents tests with not equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with in filters from `DocumentStoreBaseTests` to separate class (#6342) * Move filter_documents tests with in filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with not in filters from `DocumentStoreBaseTests` to separate class (#6343) * Move filter_documents tests with not in filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with greater than filters from `DocumentStoreBaseTests` to separate class (#6344) * Move filter_documents tests with greater than filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with greater than equal filters from `DocumentStoreBaseTests` to separate class (#6345) * Move filter_documents tests with greater than equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with less than filters from `DocumentStoreBaseTests` to separate class (#6346) * Move filter_documents tests with less than filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with less than equal filters from `DocumentStoreBaseTests` to separate class (#6347) * Move filter_documents tests with less than equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with simple logical filters from `DocumentStoreBaseTests` to separate class (#6348) * Move filter_documents tests with simple logical filters from DocumentStoreBaseTests to separate class * Move filter_documents tests with nested logical filters from DocumentStoreBaseTests to separate class (#6349)
silvanocerza
merged commit 75c880d
into
move-filterable-docs-fixture
6 of 7 checks passed
silvanocerza
added a commit
that referenced
this pull request
Nov 17, 2023
…ate mixin class (#6337) * Move filterable_docs fixture from DocumentStoreBaseTests to separate mixin class * refactor: Move generic `filter_documents` tests from `DocumentStoreBaseTests` to separate class (#6338) * Move generic filter_documents tests from DocumentStoreBaseTests to separate class * refactor: Move `filter_documents` tests with invalid filters from `DocumentStoreBaseTests` to separate class (#6339) * Move filter_documents tests with invalid filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with equal filters from `DocumentStoreBaseTests` to separate class (#6340) * Move filter_documents tests with equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with not equal filters from `DocumentStoreBaseTests` to separate class (#6341) * Move filter_documents tests with not equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with in filters from `DocumentStoreBaseTests` to separate class (#6342) * Move filter_documents tests with in filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with not in filters from `DocumentStoreBaseTests` to separate class (#6343) * Move filter_documents tests with not in filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with greater than filters from `DocumentStoreBaseTests` to separate class (#6344) * Move filter_documents tests with greater than filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with greater than equal filters from `DocumentStoreBaseTests` to separate class (#6345) * Move filter_documents tests with greater than equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with less than filters from `DocumentStoreBaseTests` to separate class (#6346) * Move filter_documents tests with less than filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with less than equal filters from `DocumentStoreBaseTests` to separate class (#6347) * Move filter_documents tests with less than equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with simple logical filters from `DocumentStoreBaseTests` to separate class (#6348) * Move filter_documents tests with simple logical filters from DocumentStoreBaseTests to separate class * Move filter_documents tests with nested logical filters from DocumentStoreBaseTests to separate class (#6349)
silvanocerza
added a commit
that referenced
this pull request
Nov 17, 2023
…sts` to separate class (#6336) * Move tests for delete_documents from DocumentStoreBaseTests to separate class * Move `filterable_docs` fixture from `DocumentStoreBaseTests` to separate mixin class (#6337) * Move filterable_docs fixture from DocumentStoreBaseTests to separate mixin class * refactor: Move generic `filter_documents` tests from `DocumentStoreBaseTests` to separate class (#6338) * Move generic filter_documents tests from DocumentStoreBaseTests to separate class * refactor: Move `filter_documents` tests with invalid filters from `DocumentStoreBaseTests` to separate class (#6339) * Move filter_documents tests with invalid filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with equal filters from `DocumentStoreBaseTests` to separate class (#6340) * Move filter_documents tests with equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with not equal filters from `DocumentStoreBaseTests` to separate class (#6341) * Move filter_documents tests with not equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with in filters from `DocumentStoreBaseTests` to separate class (#6342) * Move filter_documents tests with in filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with not in filters from `DocumentStoreBaseTests` to separate class (#6343) * Move filter_documents tests with not in filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with greater than filters from `DocumentStoreBaseTests` to separate class (#6344) * Move filter_documents tests with greater than filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with greater than equal filters from `DocumentStoreBaseTests` to separate class (#6345) * Move filter_documents tests with greater than equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with less than filters from `DocumentStoreBaseTests` to separate class (#6346) * Move filter_documents tests with less than filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with less than equal filters from `DocumentStoreBaseTests` to separate class (#6347) * Move filter_documents tests with less than equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with simple logical filters from `DocumentStoreBaseTests` to separate class (#6348) * Move filter_documents tests with simple logical filters from DocumentStoreBaseTests to separate class * Move filter_documents tests with nested logical filters from DocumentStoreBaseTests to separate class (#6349)
vblagoje
pushed a commit
that referenced
this pull request
Nov 22, 2023
…sts` to separate class (#6336) * Move tests for delete_documents from DocumentStoreBaseTests to separate class * Move `filterable_docs` fixture from `DocumentStoreBaseTests` to separate mixin class (#6337) * Move filterable_docs fixture from DocumentStoreBaseTests to separate mixin class * refactor: Move generic `filter_documents` tests from `DocumentStoreBaseTests` to separate class (#6338) * Move generic filter_documents tests from DocumentStoreBaseTests to separate class * refactor: Move `filter_documents` tests with invalid filters from `DocumentStoreBaseTests` to separate class (#6339) * Move filter_documents tests with invalid filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with equal filters from `DocumentStoreBaseTests` to separate class (#6340) * Move filter_documents tests with equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with not equal filters from `DocumentStoreBaseTests` to separate class (#6341) * Move filter_documents tests with not equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with in filters from `DocumentStoreBaseTests` to separate class (#6342) * Move filter_documents tests with in filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with not in filters from `DocumentStoreBaseTests` to separate class (#6343) * Move filter_documents tests with not in filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with greater than filters from `DocumentStoreBaseTests` to separate class (#6344) * Move filter_documents tests with greater than filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with greater than equal filters from `DocumentStoreBaseTests` to separate class (#6345) * Move filter_documents tests with greater than equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with less than filters from `DocumentStoreBaseTests` to separate class (#6346) * Move filter_documents tests with less than filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with less than equal filters from `DocumentStoreBaseTests` to separate class (#6347) * Move filter_documents tests with less than equal filters from DocumentStoreBaseTests to separate class * Move `filter_documents` tests with simple logical filters from `DocumentStoreBaseTests` to separate class (#6348) * Move filter_documents tests with simple logical filters from DocumentStoreBaseTests to separate class * Move filter_documents tests with nested logical filters from DocumentStoreBaseTests to separate class (#6349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Relates to #6284
Proposed Changes:
Move generic
filter_documentstests fromDocumentStoreBaseTestsintoLegacyFilterDocumentsTestclass.DocumentStoreBaseTestsnow inheritsLegacyFilterDocumentsTest.How did you test it?
I ran tests locally.
Notes for the reviewer
Depends on #6337.
This is part of a series of PRs to split tests into different classes. I'll add release notes at the end.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.