refactor: Rework write_documents tests
#6362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
added
the
ignore-for-release-notes
github-actions
bot
added
2.x
silvanocerza
force-pushed
the
rework-write-documents-test
branch
3 times, most recently
from
464cd91
to
a825d6a
Compare
anakin87
approved these changes
Nov 20, 2023
silvanocerza
force-pushed
the
rework-write-documents-test
branch
from
223ec18
to
8fcfe10
Compare
vblagoje
pushed a commit
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related to #6284
Proposed Changes:
Rework tests for
write_documents()so they don't require filtering to be fully implemented to pass.How did you test it?
I ran tests locally.
Notes for the reviewer
This is part of a series of PRs, I'll update release notes at the end.
Depends on #6360
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.