refactor: Rework delete_documents tests
#6363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
added
the
ignore-for-release-notes
github-actions
bot
added
2.x
silvanocerza
force-pushed
the
rework-write-documents-test
branch
from
223ec18
to
8fcfe10
Compare
silvanocerza
force-pushed
the
rework-delete-documents-test
branch
from
bed56f9
to
ea84e69
Compare
vblagoje
pushed a commit
that referenced
this pull request
Nov 22, 2023
* Rework write_documents tests * Rework delete_documents tests * Fix linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related to #6284
Proposed Changes:
Rework tests for
delete_documents().This PR also changes the expected behaviour of
delete_document()to not fail when the specified to delete doesn't exist. That's much more sensible and makes the method idempotent.How did you test it?
Ran tests locally.
Notes for the reviewer
This is part of a series of PRs, I'll update release notes at the end.
Depends on #6362
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.