Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): lint now waits until exiting the loop to write to file, handles multiple validation results #504

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

mike-winberry
Copy link
Collaborator

@mike-winberry mike-winberry commented Jun 27, 2024

Description

  • lint now waits until exiting the loop to write to file
  • handles multiple validation results
  • still fatal if any one doc fails linting
  • still bail if any non-linting error is encountered
  • waits to exit until results are written

Related Issue

#481

@mike-winberry
Copy link
Collaborator Author

Screenshot 2024-06-26 at 7 18 07 PM

…prior to deciding exit state, still bails on non-validation errors as they happen
@mike-winberry
Copy link
Collaborator Author

Screen.Recording.2024-06-26.at.8.09.15.PM.mov

Copy link
Collaborator

@CloudBeard CloudBeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@CloudBeard CloudBeard merged commit b80d607 into 480-feat-add-lint--loop Jun 27, 2024
2 checks passed
@CloudBeard CloudBeard deleted the cole-noodle branch June 27, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants