fix(lint): lint now waits until exiting the loop to write to file, handles multiple validation results

src/cmd/tools/lint.go

@@ -2,6 +2,8 @@ package tools
 
 import (
 	"encoding/json"
+	"fmt"
+	"strings"
 
 	"github.com/defenseunicorns/go-oscal/src/pkg/validation"
 	"github.com/defenseunicorns/lula/src/config"
@@ -31,6 +33,7 @@ func init() {
 		Long:    "Validate OSCAL documents are properly configured against the OSCAL schema",
 		Example: lintHelp,
 		Run: func(cmd *cobra.Command, args []string) {
+			var validationResults []validation.ValidationResult
 			if len(opts.InputFiles) == 0 {
 				message.Fatalf(nil, "No input files specified")
 			}
@@ -49,28 +52,48 @@ func init() {
 					message.Warn(warning)
 				}
 
-				if opts.ResultFile != "" {
-					validation.WriteValidationResult(validationResp.Result, opts.ResultFile)
-				} else {
+				// append the validation result to the results array
+				validationResults = append(validationResults, validationResp.Result)
+
+				// If result file is not specified, print the validation result
+				if opts.ResultFile == "" {
 					jsonBytes, err := json.MarshalIndent(validationResp.Result, "", "  ")
 					if err != nil {
 						message.Fatalf(err, "Failed to marshal validation result")
 					}
 					message.Infof("Validation result for %s: %s", inputFile, string(jsonBytes))
 				}
-
-				if validationResp.JsonSchemaError != nil {
-					message.Fatalf(err, "Failed to lint %s", inputFile)
-				}
-
 				// New conditional for logging success or failed linting
 				if validationResp.Result.Valid {
 					message.Infof("Successfully validated %s is valid OSCAL version %s %s\n", inputFile, validationResp.Validator.GetSchemaVersion(), validationResp.Validator.GetModelType())
 					spinner.Success()
 				} else {
-					message.Fatalf(nil, "Failed linting for %s", inputFile)
+					message.WarnErrf(nil, "Failed to lint %s", inputFile)
+					spinner.Stop()
 				}
 			}
+
+			// If result file is specified, write the validation results to the file
+			if opts.ResultFile != "" {
+				// If there is only one validation result, write it to the file
+				if len(validationResults) == 1 {
+					validation.WriteValidationResult(validationResults[0], opts.ResultFile)
+				} else {
+					// If there are multiple validation results, write them to the file
+					validation.WriteValidationResults(validationResults, opts.ResultFile)
+				}
+			}
+
+			// If there is at least one validation result that is not valid, exit with a fatal error
+			failedFiles := []string{}
+			for _, result := range validationResults {
+				if !result.Valid {
+					failedFiles = append(failedFiles, result.Metadata.DocumentPath)
+				}
+			}
+			if len(failedFiles) > 0 {
+				message.Fatal(nil, fmt.Sprintf("The following files failed linting: %s", strings.Join(failedFiles, ", ")))
+			}
 		},
 	}
 
@@ -79,4 +102,3 @@ func init() {
 	lintCmd.Flags().StringSliceVarP(&opts.InputFiles, "input-files", "f", []string{}, "the paths to oscal json schema files (comma-separated)")
 	lintCmd.Flags().StringVarP(&opts.ResultFile, "result-file", "r", "", "the path to write the validation result")
 }
-