Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Opa provider + Kubernetes data source + E2E test #82

Merged
merged 14 commits into from
Oct 19, 2023

Conversation

brandtkeller
Copy link
Member

@brandtkeller brandtkeller commented Oct 15, 2023

A lot to discuss here and a lot to learn. I understand there is a lot of tribal knowledge around OSCAL and such - mainly looking for any red flags as it pertains to the code.

Core focus of review would be around:

  • OPA validation logic
  • Kubernetes resource collection logic

Testing made it more obvious that we may want to break down the validate logic further - more library code outside the CLI and maybe finding ways to further utilize or remove the ReportObject reference.

If I am breaking fundamental best practices anywhere - please let me know. I have a lot to learn in the space of Kubernetes API/types and more Golang best practices.

Working on the actual payload in OSCAL currently as an urgent priority - so expecting the payload location in OSCAL to change.

@brandtkeller brandtkeller marked this pull request as ready for review October 16, 2023 23:54
Copy link
Collaborator

@CloudBeard CloudBeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of putting the validation rule in the oscal where you say this is how we are meeting X control. Should eliminate any confusion on proving you're doing what you just said you're doing.

E2E testing works with make test and using kind locally for me.

Only question/comment I have is using the sha instead of version tag for github actions but that can be updated when we setup rennovate to make sure its all the same versions etc.

@brandtkeller brandtkeller merged commit 5eaf90b into main Oct 19, 2023
3 checks passed
This was referenced Oct 20, 2023
@brandtkeller brandtkeller deleted the opa-provider branch October 22, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants