fix: update maru-runner to silence info log #925

catsby · 2024-09-18T19:31:36Z

Description

Remove the Saving log file note thats immediately present when running uds run by updating maru to a version that enforces log levels, and set the log level to warn.

NOTE: this PR updates uds-cli to use a branch from the maru-runner repo that has changes to logging, see defenseunicorns/maru-runner#141 . If that PR gets merged, this PR should be updated to pull from the main branch or a tagged release before merging.

Example output

Before this PR, we see a Saving log file note (as shown also in #916):

 ➜ ./build/uds-mac-apple run build-cli-mac-apple

  •  Saving log file to
       /var/folders/lk/181f8tjj7xg0c368tfmw35kr0000gn/T/maru-2024-09-18-14-33-53-205407822.log
  ✔  Completed "go list -f '{{.Version}}' -m github.com/derailed/k9s"
  ✔  Completed "go list -f '{{.Version}}' -m github.com/anchore/syft"
  [...]

After this change, if you run ./build/uds-mac-apple run build-cli-mac-apple twice, you'll see the new output (once to build the binary with the change, and a second time to actually use the new binary with the change):

 ➜ ./build/uds-mac-apple run build-cli-mac-apple
  ✔  Completed "go list -f '{{.Version}}' -m github.com/derailed/k9s"
  ✔  Completed "go list -f '{{.Version}}' -m github.com/anchore/syft"
  [...]

Related Issue

Fixes #916

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Other (security config, docs update, etc)

Checklist before merging

Test, docs, adr added or updated as needed
Contributor Guide Steps followed

catsby · 2024-09-19T21:26:08Z

defenseunicorns/maru-runner#141 has been merged, just waiting on the next maru release to update this PR

Signed-off-by: catsby <clint@ctshryock.com>

UncleGedd

perf

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [defenseunicorns/uds-cli](https://redirect.github.com/defenseunicorns/uds-cli) | minor | `0.15.0` -> `0.16.0` | | [defenseunicorns/uds-cli](https://redirect.github.com/defenseunicorns/uds-cli) | minor | `v0.15.0` -> `v0.16.0` | --- ### Release Notes <details> <summary>defenseunicorns/uds-cli (defenseunicorns/uds-cli)</summary> ### [`v0.16.0`](https://redirect.github.com/defenseunicorns/uds-cli/releases/tag/v0.16.0) [Compare Source](https://redirect.github.com/defenseunicorns/uds-cli/compare/v0.15.0...v0.16.0) ##### What's Changed - fix: update renovate to hopefully fix uds-runtime dep by [@catsby](https://redirect.github.com/catsby) in [https://github.com/defenseunicorns/uds-cli/pull/928](https://redirect.github.com/defenseunicorns/uds-cli/pull/928) - chore(deps): update defenseunicorns/uds-common action to v0.13.0 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/935](https://redirect.github.com/defenseunicorns/uds-cli/pull/935) - fix(deps): update module github.com/defenseunicorns/pkg/oci to v1.0.2 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/934](https://redirect.github.com/defenseunicorns/uds-cli/pull/934) - fix(deps): update module github.com/defenseunicorns/maru-runner to v0.2.3 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/933](https://redirect.github.com/defenseunicorns/uds-cli/pull/933) - fix(deps): update kubernetes packages to v0.31.1 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/932](https://redirect.github.com/defenseunicorns/uds-cli/pull/932) - chore(deps): update module github.com/prometheus/common to v0.59.1 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/877](https://redirect.github.com/defenseunicorns/uds-cli/pull/877) - chore: manually bump uds-runtime to v0.4.0 by [@catsby](https://redirect.github.com/catsby) in [https://github.com/defenseunicorns/uds-cli/pull/938](https://redirect.github.com/defenseunicorns/uds-cli/pull/938) - fix: update maru-runner to silence info log by [@catsby](https://redirect.github.com/catsby) in [https://github.com/defenseunicorns/uds-cli/pull/925](https://redirect.github.com/defenseunicorns/uds-cli/pull/925) - chore: update uds ui docs by [@UncleGedd](https://redirect.github.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/937](https://redirect.github.com/defenseunicorns/uds-cli/pull/937) - fix: ensure runtime bins are included in releases by [@UncleGedd](https://redirect.github.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/939](https://redirect.github.com/defenseunicorns/uds-cli/pull/939) **Full Changelog**: defenseunicorns/uds-cli@nightly-unstable...v0.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* main: chore(deps): update actions/checkout action to v4.2.0 (#943) fix: add suffix to smoke test logs (#947) chore: matrix testing pre-existing k3d clusters (#944) chore: remove nascent state tracking (#942) fix: ensure runtime bins are included in releases (#939) chore: update uds ui docs (#937) fix: update maru-runner to silence info log (#925) chore: manually bump uds-runtime to v0.4.0 (#938) chore(deps): update module github.com/prometheus/common to v0.59.1 (#877) fix(deps): update kubernetes packages to v0.31.1 (#932) fix(deps): update module github.com/defenseunicorns/maru-runner to v0.2.3 (#933) fix(deps): update module github.com/defenseunicorns/pkg/oci to v1.0.2 (#934) chore(deps): update defenseunicorns/uds-common action to v0.13.0 (#935)

catsby force-pushed the silence-maru-log-note branch from 44c8d72 to dfc1a2e Compare September 18, 2024 19:32

catsby mentioned this pull request Sep 18, 2024

Remove extra output from uds run #916

Closed

catsby added this to the v0.16.0 milestone Sep 20, 2024

fix: update maru-runner to silence info log

42fe0e7

Signed-off-by: catsby <clint@ctshryock.com>

catsby force-pushed the silence-maru-log-note branch from dfc1a2e to 42fe0e7 Compare September 20, 2024 18:32

catsby marked this pull request as ready for review September 20, 2024 18:32

catsby requested review from UncleGedd, jeff-mccoy, decleaver and TristanHoladay as code owners September 20, 2024 18:32

UncleGedd approved these changes Sep 20, 2024

View reviewed changes

Merge branch 'main' into silence-maru-log-note

a6ac388

UncleGedd merged commit d9f9667 into main Sep 20, 2024
7 checks passed

UncleGedd deleted the silence-maru-log-note branch September 20, 2024 18:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update maru-runner to silence info log #925

fix: update maru-runner to silence info log #925

catsby commented Sep 18, 2024 •

edited

Loading

catsby commented Sep 19, 2024

UncleGedd left a comment

fix: update maru-runner to silence info log #925

fix: update maru-runner to silence info log #925

Conversation

catsby commented Sep 18, 2024 • edited Loading

Description

Example output

Related Issue

Type of change

Checklist before merging

catsby commented Sep 19, 2024

UncleGedd left a comment

Choose a reason for hiding this comment

catsby commented Sep 18, 2024 •

edited

Loading