Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure GitLab pages works #15

Closed
rjferguson21 opened this issue Jan 30, 2024 · 2 comments · Fixed by #106
Closed

Ensure GitLab pages works #15

rjferguson21 opened this issue Jan 30, 2024 · 2 comments · Fixed by #106
Assignees
@Racer159
Labels
enhancement ✨ New feature or request

Comments

@rjferguson21
Copy link
Contributor

rjferguson21 commented Jan 30, 2024 •
edited by naveensrinivasan
Loading

Likely need some work to make pages work.

https://github.com/defenseunicorns/uds-package-gitlab/blob/main/values/gitlab-values.yaml#L129-L139

GL Pages should be working / enabled internally but aren't properly exposed through Istio.
@rjferguson21 rjferguson21 mentioned this issue Jan 30, 2024
Merged
@Racer159 Racer159 added the enhancement ✨ New feature or request label Feb 7, 2024
@Racer159
Copy link
Contributor

Racer159 commented Apr 1, 2024

Pages is initially controlled via this var:

uds-package-gitlab/zarf.yaml

Line 27 in 625fde5

- name: GITLAB_PAGES_ENABLED

@Racer159
Copy link
Contributor

Racer159 commented Apr 1, 2024

uds-package-gitlab/values/common-values.yaml

Line 142 in 625fde5

pages:
- updated link

@Racer159 Racer159 self-assigned this Apr 3, 2024
@Racer159 Racer159 mentioned this issue Apr 7, 2024
Merged
5 tasks
Racer159 added a commit that referenced this issue Apr 17, 2024
@Racer159
chore: allow GL pages through istio (#106)
9613f76 
## Description

This PR allows GL pages to work through istio in the UDS package CR

## Related Issue

Fixes #15 

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-gitlab/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Racer159 Racer159

Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: allow GL pages through istio defenseunicorns/uds-package-gitlab
3 participants
@naveensrinivasan @rjferguson21 @Racer159