chore: allow GL pages through istio #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this as RTR for now - after thinking through testing this may be better to fully test in the GLR repo since pages requires GLR to operate (and otherwise we would create a circular dependency chain during testing). For now added pages to the health check tests and here is a manual test done locally:
|
zachariahmiller
pushed a commit
that referenced
this pull request
May 2, 2024
🤖 I have created a release *beep* *boop* --- ## [16.11.1-uds.0](v16.10.2-uds.0...v16.11.1-uds.0) (2024-05-02) ### ⚠ BREAKING CHANGES * sso failing deployment when it is disabled ([#115](#115)) * allow [templating of network policies](./docs/networking.md) in the UDS Package ([#110](#110)) ### Features * allow [templating of network policies](./docs/networking.md) in the UDS Package ([#110](#110)) ([5af09cb](5af09cb)) ### Bug Fixes * sso failing deployment when it is disabled ([#115](#115)) ([8cfdb58](8cfdb58)) ### Miscellaneous * allow GL pages through istio ([#106](#106)) ([9613f76](9613f76)) * **deps:** update gitlab package dependencies ([#112](#112)) ([a0e2c48](a0e2c48)) * **deps:** update gitlab support dependencies ([#113](#113)) ([cde79b3](cde79b3)) * **deps:** update gitlab support dependencies ([#99](#99)) ([275ccd6](275ccd6)) * migrate to upstream chart ([#72](#72)) ([b0e151e](b0e151e)) * release v16.11.1-uds.0 ([#120](#120)) ([5c13d62](5c13d62)) * switch to new SSO secret template ([#111](#111)) ([acf28bc](acf28bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows GL pages to work through istio in the UDS package CR
Related Issue
Fixes #15
Type of change
Checklist before merging