chore(actions/common.go): update filename for e2e chart #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bacongobbler, @krancour and @arschles are potential reviewers of this pull request based on my analysis of |
As location of e2e pod name will have changed in deis/charts#299. Therefore, this PR depends on deis/charts#299 being merged.
vdice
force-pushed
the
update-e2e-chart-file
branch
from
3ef97b9 to
c1aa338
Compare
| } | ||
| paramsComponentMap := getParamsComponentMap(ghClient, defaultParamsComponentAttrs, helmChart.Template, c.GlobalString(RefFlag)) | ||
| generateParams(ourFS, stagingDir, paramsComponentMap, helmChart) | ||
|
|
There was a problem hiding this comment.
There was a problem hiding this comment.
@vdice makes sense & looks good. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As location of e2e pod name will have changed in deis/charts#299.
Therefore, this PR depends on deis/charts#299 being merged.