Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve canonical generate_params.toml via GH API #11

Closed
vdice opened this issue May 2, 2016 · 1 comment
Closed

Retrieve canonical generate_params.toml via GH API #11

vdice opened this issue May 2, 2016 · 1 comment
Labels
enhancement

Comments

@vdice
Copy link
Member

vdice commented May 2, 2016

In https://github.com/deis/deisrel/blob/master/actions/generate_params.go and https://github.com/deis/deisrel/blob/master/actions/generate_params_e2e.go we construct local versions of the appropriate .toml files, but it would be better to pull the latest canonical versions of each from the deis/charts repo as these files change.
This was referenced Jun 28, 2016
Merged
Closed
arschles pushed a commit to arschles/deisrel that referenced this issue Jun 29, 2016
ref(actions,glide,helm): download canonical generate_params.toml
8d6f211 
… instead of hard-coding it

This patch also refactors much of the github plumbing and
chart-generation parsing into a new top-level helm package.

Fixes deis#11
@arschles arschles mentioned this issue Jun 29, 2016
Closed
2 tasks
@krancour krancour mentioned this issue Jul 6, 2016
Merged
@Joshua-Anderson
Copy link

This is no longer relevant as deisrel no longer updates charts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Joshua-Anderson @vdice