ref(actions,glide,helm): download canonical generate_params.toml #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of hard-coding it This patch also refactors much of the github plumbing and chart-generation parsing into a new top-level helm package. Fixes deis#11
|
@vdice, @krancour and @bacongobbler are potential reviewers of this pull request based on my analysis of |
| "Chart.yaml", | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
this and GetRouterChart could use godoc descriptions like GetWorkflowChart above
|
removing v2.2 from this PR since we're putting deisrel work on hold pending a new release process |
|
Sadly, this PR has rusted. This doesn't quite match our release process now, and we don't use Helm classic charts for Workflow. I'm going to close it, but please continue to rock on @arschles. 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard-coding it
This patch also refactors much of the github plumbing and
chart-generation parsing into a new top-level helm package.
Fixes #11
TODO:
helm/generate_params.go. This logic should turn a generate_params.toml into a go templateAssociated Documentation PR(s)
None anticipated. This should be purely an implementation change.