Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize preference dialog #4

Closed
wants to merge 10 commits into from
Closed

Resize preference dialog #4

wants to merge 10 commits into from

Conversation

ohuang12
Copy link

Fix for issue #2559.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@TRvanRossum TRvanRossum self-requested a review March 12, 2017 16:25
TRvanRossum
TRvanRossum approved these changes Mar 12, 2017
View reviewed changes
Copy link

@TRvanRossum TRvanRossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks nice to me 👍 I do wonder whether or not a horizontal scrollbar is necessary, but it can not hurt I guess.

Siedlerchr and others added 10 commits March 12, 2017 20:36
@Siedlerchr
Set POSIX filepermissions to 644 (JabRef#2637)
f0d79f8 
* Set POSIX filepermissions to 644
Fix for JabRef#2635

* Add changelog and add missing dots
@tobiasdiez
Improve perfomance of opening a database that still used the old grou…
55f6a39 
…ps format (JabRef#2636)

* Apply some post actions before displaying the file

* Add changes in JabRefGUI
@stefan-kolb
Add link to logo creator
8a07ab5
@stefan-kolb
Issuestats.com is down
a4fe1e0
@stefan-kolb
Donate to JabRef!
ef6cda5
@koppor
Update dependencies
0f0bdd4
@ohuang12 @Siedlerchr
Add option to copy title of bibentries (JabRef#2639)
9833ec4 
* Add copy title option in right click dropdown

* Add localization entries for copy title

* Add changelog entry

* Add missing localization entries

Fix the localization tests by adding several missing strings in the localization files
Use the menu localization file for the copy title menu item instead of the general localization file

* Use stream to collect titles

* Use more sensical naming for variables

Fix incorrect JavaDoc on getTitle
@stefan-kolb @Siedlerchr
Improve issue reporting a bit JabRef#2573 (JabRef#2641)
5be2d8b
@ohuang12
Add scroll bars to the preference dialog
db8b513
@ohuang12
Add changelog entry
d9a7f95
@RolfStarre RolfStarre closed this Mar 17, 2017
@RolfStarre RolfStarre deleted the resizePreferenceDialog branch March 17, 2017 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TRvanRossum TRvanRossum TRvanRossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ohuang12 @TRvanRossum @RolfStarre @Siedlerchr @tobiasdiez @stefan-kolb @koppor