Add resiliency image label and extra args in sample yaml files #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuluna
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
coulof,
Deepak-Ghivari,
gallacher,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
mjsdell,
rajendraindukuri,
rensyct,
panigs7,
tdawe,
shaynafinocchiaro,
atye and
sharmilarama
as code owners
add new config args Signed-off-by: Luna Xu <ms.luna.xu@gmail.com>
xuluna
changed the title
shaynafinocchiaro
approved these changes
Jul 21, 2023
PeresKereotubo
approved these changes
Jul 21, 2023
chimanjain
reviewed
Jul 28, 2023
| args: | ||
| - "--labelvalue=csi-isilon" | ||
| - "--arrayConnectivityPollRate=60" | ||
| - "--skipArrayConnectionValidation=false" | ||
| - "--driverPodLabelValue=dell-storage" | ||
| - "--ignoreVolumelessPods=false" | ||
| - "--arrayConnectivityPollRate=5" |
5 tasks
ChristianAtDell
added a commit
that referenced
this pull request
Oct 15, 2024
add new config args Signed-off-by: Luna Xu <ms.luna.xu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add image label to sample configuration files for resiliency so that the users can customize the image to deploy resiliency with operator. Also added the extra args as per user's request.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Deployed the driver with resiliency enabled in e2e test on a local Kubernetes setup. Modified the resiliency image to use different versions/tags and repos to verify that users can specify a different resiliency image.