Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resiliency duplicated extra args in sample yaml files #302

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

xuluna
Copy link
Contributor

@xuluna xuluna commented Jul 28, 2023

Description

Remove the duplicated arrayConnectivityPollRate args in CR yaml files.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#898

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • [] I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Deployed the driver with resiliency enabled in e2e test on a local Kubernetes setup. Modified the resiliency image to use different versions/tags and repos to verify that users can specify a different resiliency image.

Copy link
Contributor

@rensyct rensyct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the duplicate entry from the samples under tests/e2e/testfiles folder and also from pkg/modules/testdata/cr_powerstore_resiliency.yaml file

Should we not remove the duplicate args from samples/storage_csm_powerflex_v270.yaml?

@xuluna
Copy link
Contributor Author

xuluna commented Jul 31, 2023

Please remove the duplicate entry from the samples under tests/e2e/testfiles folder and also from pkg/modules/testdata/cr_powerstore_resiliency.yaml file

Should we not remove the duplicate args from samples/storage_csm_powerflex_v270.yaml?

I don't see a duplicate podmon args in storage_csm_powerflex_v270.yaml and cr_powerstore_resiliency.yaml files? This duplicates were created from my last PR #296 where a customer requested extra args in sample files. No change was made to tests/e2e/testfiles folder.

@rensyct
Copy link
Contributor

rensyct commented Jul 31, 2023

Please remove the duplicate entry from the samples under tests/e2e/testfiles folder and also from pkg/modules/testdata/cr_powerstore_resiliency.yaml file
Should we not remove the duplicate args from samples/storage_csm_powerflex_v270.yaml?

I don't see a duplicate podmon args in storage_csm_powerflex_v270.yaml and cr_powerstore_resiliency.yaml files? This duplicates were created from my last PR #296 where a customer requested extra args in sample files. No change was made to tests/e2e/testfiles folder.

I see that one is defined under controller and the other one under node.

@xuluna xuluna merged commit c91054c into main Jul 31, 2023
@xuluna xuluna deleted the luna/issue898 branch July 31, 2023 17:46
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants