-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove resiliency duplicated extra args in sample yaml files #302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the duplicate entry from the samples under tests/e2e/testfiles folder and also from pkg/modules/testdata/cr_powerstore_resiliency.yaml file
Should we not remove the duplicate args from samples/storage_csm_powerflex_v270.yaml?
I don't see a duplicate podmon args in storage_csm_powerflex_v270.yaml and cr_powerstore_resiliency.yaml files? This duplicates were created from my last PR #296 where a customer requested extra args in sample files. No change was made to tests/e2e/testfiles folder. |
I see that one is defined under controller and the other one under node. |
Description
Remove the duplicated
arrayConnectivityPollRate
args in CR yaml files.GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Deployed the driver with resiliency enabled in e2e test on a local Kubernetes setup. Modified the resiliency image to use different versions/tags and repos to verify that users can specify a different resiliency image.