Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide instruction for driver config version and authorization v2-alpha #615

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Provide instruction for driver config version and authorization v2-alpha #615

merged 3 commits into from
Jun 26, 2024

Conversation

alikdell
Copy link
Contributor

Description

Provide instruction for driver config version and authorization v2-alpha.
Driver configVersion will be 1.11.0 and user should use csm-authorization-sidecar:v2.0.0-alpha for PowerFlex Tech-Preview

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#dell/csm#1281

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • [x ] I have maintained backward compatibility

atye
atye reviewed Jun 26, 2024
View reviewed changes
samples/storage_csm_powerflex_v2110.yaml Outdated
image: dellemc/csm-authorization-sidecar:v1.11.0
# image: dellemc/csm-authorization-sidecar:v2.0.0-alpha
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need two comments for the image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure so added the image line, may be will make easier for user or it is redundant

KerryKovacevic
KerryKovacevic previously approved these changes Jun 26, 2024
View reviewed changes
atye
atye reviewed Jun 26, 2024
View reviewed changes
samples/storage_csm_powerflex_v2110.yaml Outdated
@@ -183,9 +183,11 @@ spec:
- name: authorization
# enable: Enable/Disable csm-authorization
enabled: false
# For PowerFlex Tech-Preview v2.0.0-alpha use v1.11.0 as configVersion DO NOT change the configVersion to v2.0.0-alpha
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put a period after configVersion.

@alikdell alikdell merged commit 62f5b46 into main Jun 26, 2024
8 of 9 checks passed
@alikdell alikdell deleted the krv-25717-configversion branch June 26, 2024 18:26
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Provide instruction for driver config version and authorization v2-al…
ebac610 
…pha (#615)

* Provide instruction for driver config version and authorization v2-alpha

* pr edits

* pr edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KerryKovacevic KerryKovacevic KerryKovacevic approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@atye atye atye approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alikdell @atye @shaynafinocchiaro @KerryKovacevic