Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Query Parameter for listing snapshots for dellctl support #68

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

harshitap26
Copy link
Contributor

@harshitap26 harshitap26 commented Aug 2, 2024

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1281

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

Used these changes on cam-authorization and able to list the snapshots created and get the snapshot count as well

[root@master-1-DISXduyHx8XGU bin]# ./dellctl volume ls --insecure --namespace isilon --proxy https://csm-authorization.com:30495/
NAME                           VOLUME ID   SIZE       POOL            SYSTEM ID                   PV NAME                        PV STATUS   STORAGE CLASS   PVC NAME      NAMESPACE   SNAPSHOT COUNT
k8s-csmtn1-sample-5e5557d921   478376      0.000000   /ifs/data/csi   PIE-IsilonS-24241-Cluster   k8s-csmtn1-sample-5e5557d921   Bound       isilon          pvol-isilon   default     2
[root@master-1-DISXduyHx8XGU bin]# ./dellctl snapshot ls --insecure --namespace isilon --proxy https://csm-authorization.com:30495/
NAME                                            SNAPSHOT ID   SIZE       POOL            SYSTEM ID                   ACCESS MODE   SOURCE VOLUME ID
snapshot-7d79bb9c-29e4-4796-b26e-47a6a31910fb   368472        0.000006   /ifs/data/csi   PIE-IsilonS-24241-Cluster                 478376
snapshot-afd0a9c4-156c-4b53-b828-52bba312cb20   368474        0.000006   /ifs/data/csi   PIE-IsilonS-24241-Cluster                 478376

Copy link
Collaborator

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdawe tdawe merged commit aff0b89 into main Aug 6, 2024
3 checks passed
@tdawe tdawe deleted the dellctl-support branch August 6, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants