Add Vault authentication role to values #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atye
requested review from
gallacher,
tdawe,
alikdell,
hoppea2,
chaganti-rajitha,
coulof,
meggm,
niranjan-n1,
shaynafinocchiaro,
sharmilarama,
tssushma,
taohe1012,
P-Cao,
shanmydell,
baoy1,
YianZong,
forrestxia,
nitesh3108,
rajendraindukuri,
shefali-malhotra,
panigs7,
chimanjain and
HarishH-DELL
as code owners
shaynafinocchiaro
approved these changes
May 13, 2024
tdawe
approved these changes
May 13, 2024
atye
added a commit
that referenced
this pull request
Jun 21, 2024
atye
added a commit
that referenced
this pull request
Jun 25, 2024
* add proxy-server sa * [csm-authorization]: Add Vault configuration to storage-service (#350) * Add Storage and CSMRole CRD into Authorization helm chart. (#305) * add crds * change group name * Revert "change group name" This reverts commit de262a3. * vault updates * vault agent updates * remove vault configs * revert to vautl client * configure vault certs * finish updates * revert values * revert values * revert values --------- Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> * customize namespace (#352) * Update role-service for gitops (#356) * pass in storage service to role service * remove duplicate * add tenant crd (#351) * add event watch (#396) * add csmtenants access to proxy-server (#403) * add csmtenants access to proxy-server * add csmtenants access to proxy-server * remove storage service (#411) * Use default openshift ingress (#414) * use default openshift ingress * update comments * update crds for storage, role, and tenant (#415) * [KRV-21812] Storage capacity poll interval (#416) * [KRV-21812] Added storagePollInterval param * [KRV-21812] Rename param * [KRV-21812] Move param in config map * [KRV-21812] Comment * [KRV-21812] Capitalize parameter * Sreekb/krv 17923 gitops (#419) Helm chart update to deploy Redis with sentinels. * add vault role to values (#422) * Add snapshot policy and storage service compatibility (#423) * Add snapshots create policy * Add clusterroles for storage service * Add leaderelection arg * Address PR comments * Address PR comments * chart/csm-authorization support authorization-controller deployment in cluster (#429) * add support for authorization-controller deployment in cluster * add support for authorization-controller deployment in cluster * add password to redis commander (#430) * fix rebase * address PR comments --------- Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: alikdell <52920355+alikdell@users.noreply.github.com> Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com> Co-authored-by: Bharath Sreekanth <93715158+bharathsreekanth@users.noreply.github.com> Co-authored-by: Fernando Alfaro Campos <falfarocampos@outlook.com>
shaynafinocchiaro
added a commit
that referenced
this pull request
Jul 26, 2024
* add proxy-server sa * [csm-authorization]: Add Vault configuration to storage-service (#350) * Add Storage and CSMRole CRD into Authorization helm chart. (#305) * add crds * change group name * Revert "change group name" This reverts commit de262a3. * vault updates * vault agent updates * remove vault configs * revert to vautl client * configure vault certs * finish updates * revert values * revert values * revert values --------- Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> * customize namespace (#352) * Update role-service for gitops (#356) * pass in storage service to role service * remove duplicate * add tenant crd (#351) * add event watch (#396) * add csmtenants access to proxy-server (#403) * add csmtenants access to proxy-server * add csmtenants access to proxy-server * remove storage service (#411) * Use default openshift ingress (#414) * use default openshift ingress * update comments * update crds for storage, role, and tenant (#415) * [KRV-21812] Storage capacity poll interval (#416) * [KRV-21812] Added storagePollInterval param * [KRV-21812] Rename param * [KRV-21812] Move param in config map * [KRV-21812] Comment * [KRV-21812] Capitalize parameter * Sreekb/krv 17923 gitops (#419) Helm chart update to deploy Redis with sentinels. * add vault role to values (#422) * Add snapshot policy and storage service compatibility (#423) * Add snapshots create policy * Add clusterroles for storage service * Add leaderelection arg * Address PR comments * Address PR comments * chart/csm-authorization support authorization-controller deployment in cluster (#429) * add support for authorization-controller deployment in cluster * add support for authorization-controller deployment in cluster * add password to redis commander (#430) * fix rebase * address PR comments --------- Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: alikdell <52920355+alikdell@users.noreply.github.com> Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com> Co-authored-by: Bharath Sreekanth <93715158+bharathsreekanth@users.noreply.github.com> Co-authored-by: Fernando Alfaro Campos <falfarocampos@outlook.com>
shaynafinocchiaro
added a commit
that referenced
this pull request
Jul 29, 2024
* Release 1.10.1 (#401) (#405) * Fix Helm deployment of vxflexos driver (#397) * [csm-application-mobility] Revert app mobility version changes (#399) * Revert app mobility version changes --------- Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: gallacher <35462391+gallacher@users.noreply.github.com> * Bump chart driver versions for CSM 1.11 (#407) * Luna/fix encryption (#404) * fix conflicts * Bumping reverseproxy version (#371) * COSI driver verion bump up (#370) * CSI-Sidecars version bumpup (#372) * CSI-Sidecars version bumpup * Snapshotter patch version update * app mobility version bump (#374) * change default value (#381) * version bumps (#378) * Updated CSI Metadata Version (#382) * change to deploy encryption * Update Chart.yaml * Update values.yaml * Update Chart.yaml * Update values.yaml --------- Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Luna Xu <ms.luna.xu@gmail.com> Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com> * `[charts/csi-unity]` fix: add allowedNetworks parameter (#406) * fix: add allowedNetworks parameter * change release version * [multiple charts] Set default container to driver (#409) * Remove check on maximum version of kube (#410) * Bump Observability version (#412) * Bump the module versions (#417) * Address linting errors (#450) * fix linting issues * revert version changes * [BUG]: [csi-vxflexos]: Update `controller.yaml` template (#428) * Release 1.10.1 (#401) * Fix Helm deployment of vxflexos driver (#397) * [csm-application-mobility] Revert app mobility version changes (#399) * Revert app mobility version changes --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: gallacher <35462391+gallacher@users.noreply.github.com> * Update driver/module versions for 10.0.2 (#424) * Revert "Update driver/module versions for 10.0.2 (#424)" (#425) * Update controller.yaml Removed unknown field under "spec.template.spec.affinity.nodeSelector" --------- Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: gallacher <35462391+gallacher@users.noreply.github.com> Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com> Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com> * Powermax resiliency changes (#421) * Do not install additional instance of retriever when Encryption is enabled. (#453) * Updating latest sidecar versions (#454) * update usage of allowedNetworks in unity values.yaml (#455) * Removed warning from Chart (#457) Add complex version check example back * Added the patch verb to volumesnapshotcontents/status to fix snapshots creation. (#458) Co-authored-by: JacobGros <jacobgrosner4@gmail.com> * [charts/csm-authorization]: CSM Authorization v2 (#459) * add proxy-server sa * [csm-authorization]: Add Vault configuration to storage-service (#350) * Add Storage and CSMRole CRD into Authorization helm chart. (#305) * add crds * change group name * Revert "change group name" This reverts commit de262a3. * vault updates * vault agent updates * remove vault configs * revert to vautl client * configure vault certs * finish updates * revert values * revert values * revert values --------- Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> * customize namespace (#352) * Update role-service for gitops (#356) * pass in storage service to role service * remove duplicate * add tenant crd (#351) * add event watch (#396) * add csmtenants access to proxy-server (#403) * add csmtenants access to proxy-server * add csmtenants access to proxy-server * remove storage service (#411) * Use default openshift ingress (#414) * use default openshift ingress * update comments * update crds for storage, role, and tenant (#415) * [KRV-21812] Storage capacity poll interval (#416) * [KRV-21812] Added storagePollInterval param * [KRV-21812] Rename param * [KRV-21812] Move param in config map * [KRV-21812] Comment * [KRV-21812] Capitalize parameter * Sreekb/krv 17923 gitops (#419) Helm chart update to deploy Redis with sentinels. * add vault role to values (#422) * Add snapshot policy and storage service compatibility (#423) * Add snapshots create policy * Add clusterroles for storage service * Add leaderelection arg * Address PR comments * Address PR comments * chart/csm-authorization support authorization-controller deployment in cluster (#429) * add support for authorization-controller deployment in cluster * add support for authorization-controller deployment in cluster * add password to redis commander (#430) * fix rebase * address PR comments --------- Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: alikdell <52920355+alikdell@users.noreply.github.com> Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com> Co-authored-by: Bharath Sreekanth <93715158+bharathsreekanth@users.noreply.github.com> Co-authored-by: Fernando Alfaro Campos <falfarocampos@outlook.com> * Updated SDC Version (#460) * make roundoff_file_system param to true (#462) * make roundoff_file_system param default to true (#463) * [charts/csm-authorization-v2.0] Move Authorization V2 to a new chart (#464) * move authorization v2 to separate helm chart * update v2 version in chart.yaml * add new line * remove storage secret * Updated migrator and node-rescanner versions for 1.11 (#467) * [charts/csm-application-mobility] Fix am charts (#466) * Change 0.4 -> 0.3, there is no 0.4 AM version * Update values.yaml --------- Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com> * Merge main branch into release-v1.11 branch (#468) * Release 1.10.1 (#401) * Fix Helm deployment of vxflexos driver (#397) * [csm-application-mobility] Revert app mobility version changes (#399) * Revert app mobility version changes --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: gallacher <35462391+gallacher@users.noreply.github.com> * Update driver/module versions for 10.0.2 (#424) * Revert "Update driver/module versions for 10.0.2 (#424)" (#425) * Release v1.10.2 rebase resolved (#440) * Update driver/module versions for 10.0.2 (#426) * removed extra space from sidecar suffix (#433) * Update cosi versions (#434) * Rebase branch (#436) * Update driver/module versions for 10.0.2 (#424) * Revert "Update driver/module versions for 10.0.2 (#424)" (#425) --------- Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com> * Update driver/module versions for 10.0.2 (#426) * removed extra space from sidecar suffix (#433) * Update cosi versions (#434) --------- Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com> * Revert "Release v1.10.2 rebase resolved (#440)" (#441) This reverts commit 34e764e. * Release v1.10.2 (#445) * Update driver/module versions for 10.0.2 (#426) * removed extra space from sidecar suffix (#433) * Update cosi versions (#434) * Rebase branch (#436) * Update driver/module versions for 10.0.2 (#424) * Revert "Update driver/module versions for 10.0.2 (#424)" (#425) --------- Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com> * Update driver/module versions for 10.0.2 (#426) * removed extra space from sidecar suffix (#433) * Update cosi versions (#434) * Reverse proxy issue * Reverse proxy issue (#443) --------- Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com> Co-authored-by: shefali-malhotra <91597668+shefali-malhotra@users.noreply.github.com> * Add yaml lint GitHub Action (#447) * add yamllint github action * add exception * Update helm chart validation action (#449) * remove outdated helm-validations actions and replace with updated action * don't validate maintainers * disable error on braces * update rule * update rules * update rules * ignore template and crd files * lint file * version changes * edits * ignore linting on crd files because they are autogenerated * fix chart linting * fix linting * disable chart linting temporarily * remove doc separator --------- Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: gallacher <35462391+gallacher@users.noreply.github.com> Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com> Co-authored-by: shefali-malhotra <91597668+shefali-malhotra@users.noreply.github.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> * Updated Encryption images for CSM 1.11 (#470) * Fix version mismatch in 1.11 branch (#471) * Fix version mismatch in 1.11 branch * Revert app mobility changes * Delete charts/csm-application-mobility directory (#472) * Address PR comments for "Release v1.11.0" (#473) * address PR comments * close quotation marks * add new line * make sdc image consistent * Update Health Monitor Sidecar (#474) --------- Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: gallacher <35462391+gallacher@users.noreply.github.com> Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com> Co-authored-by: bogdanNovikovDell <119313007+bogdanNovikovDell@users.noreply.github.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Luna Xu <ms.luna.xu@gmail.com> Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> Co-authored-by: mdutka-dell <115641913+mdutka-dell@users.noreply.github.com> Co-authored-by: coulof <49235405+coulof@users.noreply.github.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Waji <76054852+Waji-97@users.noreply.github.com> Co-authored-by: delldubey <Utkarsh.Dubey@dell.com> Co-authored-by: alexemc <32580729+alexemc@users.noreply.github.com> Co-authored-by: Bharath Sreekanth <93715158+bharathsreekanth@users.noreply.github.com> Co-authored-by: JacobGros <jacobgrosner4@gmail.com> Co-authored-by: alikdell <52920355+alikdell@users.noreply.github.com> Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com> Co-authored-by: Fernando Alfaro Campos <falfarocampos@outlook.com> Co-authored-by: shefali-malhotra <91597668+shefali-malhotra@users.noreply.github.com> Co-authored-by: Santhosh Lakshmanan <111809751+santhoshatdell@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: Trevor Dawe <trevor.dawe@dell.com>
harshitap26
pushed a commit
that referenced
this pull request
Aug 7, 2024
* add proxy-server sa * [csm-authorization]: Add Vault configuration to storage-service (#350) * Add Storage and CSMRole CRD into Authorization helm chart. (#305) * add crds * change group name * Revert "change group name" This reverts commit de262a3. * vault updates * vault agent updates * remove vault configs * revert to vautl client * configure vault certs * finish updates * revert values * revert values * revert values --------- Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> * customize namespace (#352) * Update role-service for gitops (#356) * pass in storage service to role service * remove duplicate * add tenant crd (#351) * add event watch (#396) * add csmtenants access to proxy-server (#403) * add csmtenants access to proxy-server * add csmtenants access to proxy-server * remove storage service (#411) * Use default openshift ingress (#414) * use default openshift ingress * update comments * update crds for storage, role, and tenant (#415) * [KRV-21812] Storage capacity poll interval (#416) * [KRV-21812] Added storagePollInterval param * [KRV-21812] Rename param * [KRV-21812] Move param in config map * [KRV-21812] Comment * [KRV-21812] Capitalize parameter * Sreekb/krv 17923 gitops (#419) Helm chart update to deploy Redis with sentinels. * add vault role to values (#422) * Add snapshot policy and storage service compatibility (#423) * Add snapshots create policy * Add clusterroles for storage service * Add leaderelection arg * Address PR comments * Address PR comments * chart/csm-authorization support authorization-controller deployment in cluster (#429) * add support for authorization-controller deployment in cluster * add support for authorization-controller deployment in cluster * add password to redis commander (#430) * fix rebase * address PR comments --------- Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: alikdell <52920355+alikdell@users.noreply.github.com> Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com> Co-authored-by: Bharath Sreekanth <93715158+bharathsreekanth@users.noreply.github.com> Co-authored-by: Fernando Alfaro Campos <falfarocampos@outlook.com>
harshitap26
pushed a commit
that referenced
this pull request
Aug 7, 2024
* add proxy-server sa * [csm-authorization]: Add Vault configuration to storage-service (#350) * Add Storage and CSMRole CRD into Authorization helm chart. (#305) * add crds * change group name * Revert "change group name" This reverts commit de262a3. * vault updates * vault agent updates * remove vault configs * revert to vautl client * configure vault certs * finish updates * revert values * revert values * revert values --------- Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> * customize namespace (#352) * Update role-service for gitops (#356) * pass in storage service to role service * remove duplicate * add tenant crd (#351) * add event watch (#396) * add csmtenants access to proxy-server (#403) * add csmtenants access to proxy-server * add csmtenants access to proxy-server * remove storage service (#411) * Use default openshift ingress (#414) * use default openshift ingress * update comments * update crds for storage, role, and tenant (#415) * [KRV-21812] Storage capacity poll interval (#416) * [KRV-21812] Added storagePollInterval param * [KRV-21812] Rename param * [KRV-21812] Move param in config map * [KRV-21812] Comment * [KRV-21812] Capitalize parameter * Sreekb/krv 17923 gitops (#419) Helm chart update to deploy Redis with sentinels. * add vault role to values (#422) * Add snapshot policy and storage service compatibility (#423) * Add snapshots create policy * Add clusterroles for storage service * Add leaderelection arg * Address PR comments * Address PR comments * chart/csm-authorization support authorization-controller deployment in cluster (#429) * add support for authorization-controller deployment in cluster * add support for authorization-controller deployment in cluster * add password to redis commander (#430) * fix rebase * address PR comments --------- Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: alikdell <52920355+alikdell@users.noreply.github.com> Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com> Co-authored-by: Bharath Sreekanth <93715158+bharathsreekanth@users.noreply.github.com> Co-authored-by: Fernando Alfaro Campos <falfarocampos@outlook.com>
shaynafinocchiaro
added a commit
that referenced
this pull request
Aug 8, 2024
* add proxy-server sa * [csm-authorization]: Add Vault configuration to storage-service (#350) * Add Storage and CSMRole CRD into Authorization helm chart. (#305) * add crds * change group name * Revert "change group name" This reverts commit de262a3. * vault updates * vault agent updates * remove vault configs * revert to vautl client * configure vault certs * finish updates * revert values * revert values * revert values --------- Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> * customize namespace (#352) * Update role-service for gitops (#356) * pass in storage service to role service * remove duplicate * add tenant crd (#351) * add event watch (#396) * add csmtenants access to proxy-server (#403) * add csmtenants access to proxy-server * add csmtenants access to proxy-server * remove storage service (#411) * Use default openshift ingress (#414) * use default openshift ingress * update comments * update crds for storage, role, and tenant (#415) * [KRV-21812] Storage capacity poll interval (#416) * [KRV-21812] Added storagePollInterval param * [KRV-21812] Rename param * [KRV-21812] Move param in config map * [KRV-21812] Comment * [KRV-21812] Capitalize parameter * Sreekb/krv 17923 gitops (#419) Helm chart update to deploy Redis with sentinels. * add vault role to values (#422) * Add snapshot policy and storage service compatibility (#423) * Add snapshots create policy * Add clusterroles for storage service * Add leaderelection arg * Address PR comments * Address PR comments * chart/csm-authorization support authorization-controller deployment in cluster (#429) * add support for authorization-controller deployment in cluster * add support for authorization-controller deployment in cluster * add password to redis commander (#430) * fix rebase * address PR comments --------- Co-authored-by: Luna Xu <10015938+xuluna@users.noreply.github.com> Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: alikdell <52920355+alikdell@users.noreply.github.com> Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com> Co-authored-by: Bharath Sreekanth <93715158+bharathsreekanth@users.noreply.github.com> Co-authored-by: Fernando Alfaro Campos <falfarocampos@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart?
No
What this PR does / why we need it:
Makes Vault authentication role configurable.
Which issue(s) is this PR associated with:
dell/csm#1281
Special notes for your reviewer:
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]) if applicable