Python API for restoring delta table #903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @tdas, |
vkorukanti
requested changes
Jan 25, 2022
There was a problem hiding this comment.
Thanks @Maks-D for the PR. The PR looks good. Minor comments. I am wondering if you could split this into two PRs (one PR handling the python API and other other one handling the refactoring)
| self.__overwriteDeltaTable([('a', 3), ('b', 2)], | ||
| schema=["key_new", "value_new"], | ||
| overwriteSchema='true') | ||
|
|
There was a problem hiding this comment.
Add check to verify that data has changed?
self.__checkAnswer(restored, [Row(key='a', value=3), Row(key='b', value=2)])?
Similarly in the above test
There was a problem hiding this comment.
Both tests are updated
* Add possibility to restore delta table using version or timestamp from pyspark
Examples:
```
DeltaTable.forPath(spark, path).restoreToVersion(0)
DeltaTable.forPath(spark, path).restoreToTimestamp('2021-01-01 01:01-01')
```
Fixes delta-io#890
Signed-off-by: Maksym Dovhal <maksym.dovhal@gmail.com>
Maks-D
force-pushed
the
python_api_for_deltatable_restore
branch
from
2550587
to
f5af1c6
Compare
|
@vkorukanti Thank you for review. |
allisonport-db
pushed a commit
that referenced
this pull request
Feb 4, 2022
* Add possibility to restore delta table using version or timestamp from pyspark
Examples:
```
DeltaTable.forPath(spark, path).restoreToVersion(0)
DeltaTable.forPath(spark, path).restoreToTimestamp('2021-01-01 01:01-01')
```
Tested by unit tests.
Fixes #890
Signed-off-by: Maksym Dovhal <maksym.dovhal@gmail.com>
Closes #903
Signed-off-by: Venki Korukanti <venki.korukanti@databricks.com>
GitOrigin-RevId: 8ca6a3643d97b1a95ebf3a48edcb23f4f2adb6f4
jbguerraz
pushed a commit
to jbguerraz/delta
that referenced
this pull request
Jul 6, 2022
* Add possibility to restore delta table using version or timestamp from pyspark
Examples:
```
DeltaTable.forPath(spark, path).restoreToVersion(0)
DeltaTable.forPath(spark, path).restoreToTimestamp('2021-01-01 01:01-01')
```
Tested by unit tests.
Fixes delta-io#890
Signed-off-by: Maksym Dovhal <maksym.dovhal@gmail.com>
Closes delta-io#903
Signed-off-by: Venki Korukanti <venki.korukanti@databricks.com>
GitOrigin-RevId: 8ca6a3643d97b1a95ebf3a48edcb23f4f2adb6f4
jbguerraz
pushed a commit
to jbguerraz/delta
that referenced
this pull request
Jul 6, 2022
* Add possibility to restore delta table using version or timestamp from pyspark
Examples:
```
DeltaTable.forPath(spark, path).restoreToVersion(0)
DeltaTable.forPath(spark, path).restoreToTimestamp('2021-01-01 01:01-01')
```
Tested by unit tests.
Fixes delta-io#890
Signed-off-by: Maksym Dovhal <maksym.dovhal@gmail.com>
Closes delta-io#903
Signed-off-by: Venki Korukanti <venki.korukanti@databricks.com>
GitOrigin-RevId: 8ca6a3643d97b1a95ebf3a48edcb23f4f2adb6f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples:
Tested by unit tests.
Fixes #890
Signed-off-by: Maksym Dovhal maksym.dovhal@gmail.com