Refactoring and optimisation of RestoreTableCommand #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RestoreTableCommand moved to org.apache.spark.sql.delta.commands package * cache() of filesToRemove DataFame removed (according to delta-io#863 (comment)) * cache() of filesToAdd will be applied only if spark.sql.files.ignoreMissingFiles = false (default value) Signed-off-by: Maksym Dovhal <maksym.dovhal@gmail.com>
vkorukanti
reviewed
Jan 28, 2022
core/src/main/scala/org/apache/spark/sql/delta/commands/RestoreTableCommand.scala
Outdated
Show resolved
Hide resolved
|
@vkorukanti Could you take a look on updates. I've updated PR description accordingly. |
vkorukanti
reviewed
Jan 31, 2022
core/src/main/scala/org/apache/spark/sql/delta/commands/RestoreTableCommand.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/delta/commands/RestoreTableCommand.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/delta/commands/RestoreTableCommand.scala
Outdated
Show resolved
Hide resolved
|
@vkorukanti Thank you for review. I've updated PR according to review comments. |
allisonport-db
pushed a commit
that referenced
this pull request
Feb 4, 2022
* RestoreTableCommand moved to org.apache.spark.sql.delta.commands package * cache() of filesToRemove DataFame removed (according to #863 (comment)) * cache() of filesToAdd will be applied only if spark.sql.files.ignoreMissingFiles = false (default value) Signed-off-by: Maksym Dovhal <maksym.dovhal@gmail.com> Closes #912 Signed-off-by: Venki Korukanti <venki.korukanti@databricks.com> GitOrigin-RevId: b10707c96766f74423874f01898587f97c69c6b5
jbguerraz
pushed a commit
to jbguerraz/delta
that referenced
this pull request
Jul 6, 2022
* RestoreTableCommand moved to org.apache.spark.sql.delta.commands package * cache() of filesToRemove DataFame removed (according to delta-io#863 (comment)) * cache() of filesToAdd will be applied only if spark.sql.files.ignoreMissingFiles = false (default value) Signed-off-by: Maksym Dovhal <maksym.dovhal@gmail.com> Closes delta-io#912 Signed-off-by: Venki Korukanti <venki.korukanti@databricks.com> GitOrigin-RevId: b10707c96766f74423874f01898587f97c69c6b5
jbguerraz
pushed a commit
to jbguerraz/delta
that referenced
this pull request
Jul 6, 2022
* RestoreTableCommand moved to org.apache.spark.sql.delta.commands package * cache() of filesToRemove DataFame removed (according to delta-io#863 (comment)) * cache() of filesToAdd will be applied only if spark.sql.files.ignoreMissingFiles = false (default value) Signed-off-by: Maksym Dovhal <maksym.dovhal@gmail.com> Closes delta-io#912 Signed-off-by: Venki Korukanti <venki.korukanti@databricks.com> GitOrigin-RevId: b10707c96766f74423874f01898587f97c69c6b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maksym Dovhal maksym.dovhal@gmail.com