Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use imports_layout in rustfmt once it becomes stable. #2347

Closed
ry opened this issue May 13, 2019 · 0 comments · Fixed by #17421
Closed

use imports_layout in rustfmt once it becomes stable. #2347

ry opened this issue May 13, 2019 · 0 comments · Fixed by #17421
Labels
build build system or continuous integration related

Comments

@ry
Copy link
Member

ry commented May 13, 2019

The "vertical" configuration will reduce merge difficulties.

rust-lang/rustfmt#3361
@ry ry added the build build system or continuous integration related label May 13, 2019
@ry ry mentioned this issue May 13, 2019
Closed
@bartlomieju bartlomieju mentioned this issue Jul 31, 2019
Closed
@littledivy littledivy mentioned this issue Jan 14, 2023
Merged
littledivy added a commit that referenced this issue Jan 15, 2023
@littledivy
chore: use rustfmt imports_granularity option (#17421)
d563416 
Closes #2699
Closes #2347

Uses unstable rustfmt features. Since dprint invokes `rustfmt` we do not
need to switch the cargo toolchain to nightly. Do we care about
formatting stability of our codebase across Rust versions? (I don't)
bartlomieju pushed a commit that referenced this issue Jan 16, 2023
@littledivy @bartlomieju
chore: use rustfmt imports_granularity option (#17421)
9be8f61 
Closes #2699
Closes #2347

Uses unstable rustfmt features. Since dprint invokes `rustfmt` we do not
need to switch the cargo toolchain to nightly. Do we care about
formatting stability of our codebase across Rust versions? (I don't)
mmastrac pushed a commit to denoland/deno_core that referenced this issue Jun 29, 2023
@littledivy
chore: use rustfmt imports_granularity option (#17421)
5f40ee7 
Closes denoland/deno#2699
Closes denoland/deno#2347

Uses unstable rustfmt features. Since dprint invokes `rustfmt` we do not
need to switch the cargo toolchain to nightly. Do we care about
formatting stability of our codebase across Rust versions? (I don't)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build build system or continuous integration related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use rustfmt imports_granularity option littledivy/deno
1 participant
@ry