Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustfmt is not correctly wrapping at 80 columns #2699

Closed
ry opened this issue Jul 31, 2019 · 3 comments · Fixed by #17421
Closed

rustfmt is not correctly wrapping at 80 columns #2699

ry opened this issue Jul 31, 2019 · 3 comments · Fixed by #17421
Labels
build build system or continuous integration related feat new feature (which has been agreed to/accepted) upstream Changes in upstream are required to solve these issues

Comments

@ry
Copy link
Member

ry commented Jul 31, 2019 •
edited
Loading

https://github.com/denoland/deno/pull/2683/files#r309166774

deno/cli/file_fetcher.rs

Line 33 in 695c4a2

/// `redirect_source_url` will contain original URL and `url` will be equal to final location.

Seems we need wrap_comments = true https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#wrap_comments

Additionally we need to upgrade our rustfmt binaries... We are using rustfmt 0.99.1-stable (da17b689 2018-08-04)
@ry ry mentioned this issue Jul 31, 2019
Merged
@bartlomieju
Copy link
Member

bartlomieju commented Jul 31, 2019 •
edited
Loading

Lines are also not wrapped for regular code:

      panic!("TypeScript module has no JS source, did you forget to run it through compiler?");

The problem with wrap_comments = true is that it's only available in nightly (the same as #2347)

@stale
Copy link

stale bot commented Jan 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 6, 2021
@kitsonk
Copy link
Contributor

kitsonk commented Jan 7, 2021

Here is the issue tracking stability on wrap_comments: rust-lang/rustfmt#3347 It hasn't changed in over a year.

@stale stale bot removed the stale label Jan 7, 2021
@kitsonk kitsonk added build build system or continuous integration related feat new feature (which has been agreed to/accepted) upstream Changes in upstream are required to solve these issues labels Jan 7, 2021
@littledivy littledivy mentioned this issue Jan 14, 2023
Merged
littledivy added a commit that referenced this issue Jan 15, 2023
@littledivy
chore: use rustfmt imports_granularity option (#17421)
d563416 
Closes #2699
Closes #2347

Uses unstable rustfmt features. Since dprint invokes `rustfmt` we do not
need to switch the cargo toolchain to nightly. Do we care about
formatting stability of our codebase across Rust versions? (I don't)
bartlomieju pushed a commit that referenced this issue Jan 16, 2023
@littledivy @bartlomieju
chore: use rustfmt imports_granularity option (#17421)
9be8f61 
Closes #2699
Closes #2347

Uses unstable rustfmt features. Since dprint invokes `rustfmt` we do not
need to switch the cargo toolchain to nightly. Do we care about
formatting stability of our codebase across Rust versions? (I don't)
mmastrac pushed a commit to denoland/deno_core that referenced this issue Jun 29, 2023
@littledivy
chore: use rustfmt imports_granularity option (#17421)
5f40ee7 
Closes denoland/deno#2699
Closes denoland/deno#2347

Uses unstable rustfmt features. Since dprint invokes `rustfmt` we do not
need to switch the cargo toolchain to nightly. Do we care about
formatting stability of our codebase across Rust versions? (I don't)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build build system or continuous integration related feat new feature (which has been agreed to/accepted) upstream Changes in upstream are required to solve these issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use rustfmt imports_granularity option littledivy/deno
3 participants
@ry @kitsonk @bartlomieju