-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert all Flatbuffer ops to JSON #2801
Comments
I'll take these for a good start:
|
I can work on metrics.rs |
I should convert following files tomorrow:
|
Hello @ry, may I ask why do you want to convert everything to JSON? Did you find it faster than flatbuffers? |
@s-panferov actually the opposite - we found flatbuffers too slow and we don’t yet know the speed of this JSON serialization. The other ops are not measured in our benchmarks - so we don’t particularly care how fast they are. More important is the ease of implementing and maintaining them. The flatbuffer API is unfortunately very verbose. It also complicated our build at a time when we’re trying to move from gn/ninja to cargo based. So the JSON serialization will help simplify things and not effect the benchmarks. |
@ry I believe |
I think I'm gonna go ahead and port remaining ops from |
To all contributors who are listening -
We want to convert all of the flatbuffer ops to JSON. Here is a commit showing how to do it. And another.
There's many ops to convert, and if you are interested, this is would be a helpful contribution.
I'm currently working on js/os.ts - please let me know if you want to work on some of the ops, I'll try to coordinate people so there's no double work happening. Base work off #2799
Here is a list of ops we need to convert:
The only ops we are not converting are read, write, readSync, and writeSync.
The text was updated successfully, but these errors were encountered: