Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port ops to JSON (list insde) #2809

Merged
merged 18 commits into from
Aug 24, 2019
Merged

port ops to JSON (list insde) #2809

merged 18 commits into from
Aug 24, 2019

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Aug 23, 2019 •
edited
Loading

  • metrics.rs
  • net.ts
  • performance.rs
  • permissions.rs
  • process.rs
  • random.rs
  • repl.rs
  • resources.rs
  • timers.rs
  • workers.rs

@bartlomieju
port ops to json ops
349c245 
* cli/ops/files.rs:
  * op_open
  * op_close
  * op_seek
* cli/ops/fetch.rs:
  * op_fetch
* cli/ops/compiler.rs:
  * op_cache
  * op_fetch_source_file
* cli/ops/errors.rs:
  * op_apply_source_map
  * op_format_error
@ry ry mentioned this pull request Aug 23, 2019
Closed
@bartlomieju
Copy link
Member Author

@ry ready for review as well 😅 This PR should be landed after #2804 to adjust op ids properly

@bartlomieju bartlomieju changed the title port ops to JSON (net, random, repl, resources) port ops to JSON (net, performance, random, repl, resources, timers) Aug 23, 2019
@bartlomieju bartlomieju changed the title port ops to JSON (net, performance, random, repl, resources, timers) port ops to JSON (net, performance, permissions, random, repl, resources, timers) Aug 23, 2019
@bartlomieju bartlomieju changed the title port ops to JSON (net, performance, permissions, random, repl, resources, timers) port ops to JSON (list insde) Aug 23, 2019
@bartlomieju bartlomieju mentioned this pull request Aug 24, 2019
Merged
@bartlomieju
Copy link
Member Author

Waiting for #2804

@bartlomieju
Copy link
Member Author

Merged master and ported metrics.rs as well

ry
ry reviewed Aug 24, 2019
View reviewed changes
cli/ops/repl.rs Outdated Show resolved Hide resolved
ry
ry approved these changes Aug 24, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for all this!

@ry ry merged commit 137f337 into denoland:master Aug 24, 2019
@bartlomieju bartlomieju deleted the port_ops_4 branch August 24, 2019 15:33
@nayeemrmn nayeemrmn mentioned this pull request Aug 24, 2019
Closed
ry added a commit to ry/deno that referenced this pull request Aug 24, 2019
@ry
Revert "port more ops to JSON (denoland#2809)"
6ab0941 
This reverts commit 137f337.
ry added a commit that referenced this pull request Aug 24, 2019
@ry
Revert json ops (#2814)
2235dd7 
* Revert "port more ops to JSON (#2809)"

This reverts commit 137f337.

* Revert "port ops to JSON: compiler, errors, fetch, files (#2804)"

This reverts commit 79f82cf.

* Revert "Port rest of os ops to JSON (#2802)"

This reverts commit 5b2baa5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @ry