Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting ops to json #2 #2802

Merged
merged 2 commits into from
Aug 24, 2019
Merged

Porting ops to json #2 #2802

merged 2 commits into from
Aug 24, 2019

Conversation

ry
Copy link
Member

@ry ry commented Aug 22, 2019 •
edited
Loading

No description provided.

@ry ry mentioned this pull request Aug 22, 2019
Merged
@ry ry force-pushed the port_ops branch 2 times, most recently from fa101c1 to 79747c8 Compare August 22, 2019 04:31
@ry ry changed the title Porting ops #1 Porting ops to json #2 Aug 22, 2019
@ry ry mentioned this pull request Aug 22, 2019
Closed
@bartlomieju bartlomieju mentioned this pull request Aug 22, 2019
Merged
4 tasks
@ry
Port rest of os ops to JSON
8de1b7f 
homeDir, setEnv, start
@ry ry requested a review from piscisaureus August 23, 2019 15:16
piscisaureus
piscisaureus approved these changes Aug 24, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@ry ry merged commit 5b2baa5 into denoland:master Aug 24, 2019
ry added a commit to ry/deno that referenced this pull request Aug 24, 2019
@ry
Revert "Port rest of os ops to JSON (denoland#2802)"
ea63574 
This reverts commit 5b2baa5.
ry added a commit that referenced this pull request Aug 24, 2019
@ry
Revert json ops (#2814)
2235dd7 
* Revert "port more ops to JSON (#2809)"

This reverts commit 137f337.

* Revert "port ops to JSON: compiler, errors, fetch, files (#2804)"

This reverts commit 79f82cf.

* Revert "Port rest of os ops to JSON (#2802)"

This reverts commit 5b2baa5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ry @piscisaureus