Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response constructor is non-standard #4667

Closed
ry opened this issue Apr 7, 2020 · 3 comments · Fixed by #5787
Closed

Response constructor is non-standard #4667

ry opened this issue Apr 7, 2020 · 3 comments · Fixed by #5787
Assignees
@ry
Labels
bug Something isn't working correctly

Comments

@ry
Copy link
Member

ry commented Apr 7, 2020

This is what we're using:

https://github.com/denoland/deno/blob/v0.39.0/cli/js/web/fetch.ts#L286-L295

Compare with

https://github.com/microsoft/TypeScript/blob/3398c9bfe1e474e2f81e5ea05d01645e329e5860/src/lib/dom.generated.d.ts#L12604
@kitsonk
Copy link
Contributor

kitsonk commented Apr 7, 2020

Yucky...

I am in the throws of cleaning up events to align them to the standards, but this is another one.

@ry ry added bug Something isn't working correctly and removed high priority labels May 1, 2020
@jimmywarting
Copy link
Contributor

Well, this was unexpected when i first tried out new Response('foo').arrayBuffer()

@marcosc90
Copy link
Contributor

I'm currently working on this.

marcosc90 added a commit to marcosc90/deno that referenced this issue May 23, 2020
@marcosc90
Make Response constructor standard
df08a06 
Fixes denoland#4667
marcosc90 added a commit to marcosc90/deno that referenced this issue May 23, 2020
@marcosc90
Make Response constructor standard
540b51c 
Fixes denoland#4667 denoland#4748
@marcosc90 marcosc90 mentioned this issue May 23, 2020
Merged
3 tasks
@ry ry closed this as completed in #5787 May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ry ry

Labels
bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli/web/fetch): Make Response constructor standard marcosc90/deno
5 participants
@ry @jimmywarting @kitsonk @marcosc90 @bartlomieju