Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are two independent Body classes #4748

Closed
ry opened this issue Apr 14, 2020 · 2 comments
Closed

There are two independent Body classes #4748

ry opened this issue Apr 14, 2020 · 2 comments
Labels
cli related to cli/ dir web related to Web APIs

Comments

@ry
Copy link
Member

ry commented Apr 14, 2020

export class Body implements domTypes.Body {

class Body

I don't know how it got this way, but it needs to be fixed.

It's not even clear to me that we need an actual runtime Body object. It's not something in the DOM. It's more of an internal interface to describe Request and Response. Likely there should be zero "class Body" in our code.

@kitsonk
Copy link
Contributor

kitsonk commented Apr 14, 2020

Correct, according to the spec, it is just a logical interface. It shouldn't exist as a thing. Looking at the current implementation though, it is going to be a bit of a challenge to unpick.

As I mentioned directly Ry, I am doing a re-write of the streams. Once that is done, it feels like this needs a good hose-down as well.

@bartlomieju bartlomieju added cli related to cli/ dir web related to Web APIs labels May 21, 2020
marcosc90 added a commit to marcosc90/deno that referenced this issue May 23, 2020
@bartlomieju
Copy link
Member

Fixed in #6793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli related to cli/ dir web related to Web APIs
Projects
None yet
Development

No branches or pull requests

3 participants