chore: move more tests away from itest #22909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Mar 13, 2024
| output: "jsr/no_module_graph/main.out", | ||
| envs: env_vars_for_jsr_tests(), | ||
| http_server: true, | ||
| }); |
There was a problem hiding this comment.
@nathanwhit it might be a little challenging to move this automatically. We could maybe handle certain situations like where we see something like jsr/node_module_graph/main.out then seeing jsr/node_module_graph/ being used in the args too, Then stripping that from the args and output, moving this to the json, and copying/moving the folder over.
dsherret
changed the title
…and#22878) Does a package resolve when resolving types for a directory (copying the behaviour that typescript does).
…oland#22906) Better example to close denoland#22600 --------- Signed-off-by: Matt Mastracci <matthew@mastracci.com>
Stub implementation of getCipherInfo(). Good enough for most cases. Note: We do not support all OpenSSL ciphers (likely never will) Fixes denoland#21805
Fixes denoland#18972 Support for web-push VAPID keys & jws signing - Fixes EC keygen to return raw private key and uncompressed public key point. - Support for `EC PRIVATE KEY`
Forward 1.41.3 release commit Co-authored-by: denobot <33910674+denobot@users.noreply.github.com> Co-authored-by: nathanwhit <nathanwhit@users.noreply.github.com>
…e config file (denoland#22924) Investigation from denoland#17298
Avoids the comment diagnostic that vscode gives. Also, automatically renames .json to .jsonc for the time being.
|
Ooops, looks like something went wrong during the merge. Make sure to remove all the attributions before landing |
|
Yeah, I'm not sure what I did, but code is fine. I'll squash it. |
bartlomieju
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #22907