Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal - Deprecate usage of itest #22907

Open
14 of 34 tasks
dsherret opened this issue Mar 13, 2024 · 12 comments
Open
14 of 34 tasks

Internal - Deprecate usage of itest #22907

dsherret opened this issue Mar 13, 2024 · 12 comments
Labels
chore something that we should get around to eventually good first issue Good for newcomers tests related to tests

Comments

@dsherret
Copy link
Member

dsherret commented Mar 13, 2024

We'd like to deprecate the usage of itest and move the tests over to https://github.com/denoland/deno/tree/main/tests/specs

  • bench_tests.rs
  • bundle_tests.rs
  • cache_tests.rs
  • cert_tests.rs
  • check_tests.rs
  • compile_tests.rs
  • coverage_tests.rs
  • doc_tests.rs
  • eval_tests.rs
  • flags_tests.rs
  • fmt_tests.rs
  • info_tests.rs
  • init_tests.rs
  • inspector_tests.rs
  • install_tests.rs
  • js_unit_tests.rs
  • jsr_tests.rs
  • jupyter_tests.rs
  • lint_tests.rs
  • lsp_tests.rs
  • node_compat_tests.rs
  • node_unit_tests.rs
  • npm_tests.rs
  • pm_tests.rs
  • publish_tests.rs
  • repl_tests.rs
  • run_tests.rs
  • shared_library_tests.rs
  • task_tests.rs
  • test_tests.rs
  • upgrade_tests.rs
  • vendor_tests.rs
  • watcher_tests.rs
  • worker_tests.rs
@dsherret dsherret added the chore something that we should get around to eventually label Mar 13, 2024
dsherret added a commit that referenced this issue Mar 15, 2024
@lucacasonato lucacasonato added the tests related to tests label Jun 12, 2024
@HasanAlrimawi
Copy link
Contributor

Since it's titled as "Internal": Does it mean only by Deno members, as I'm interested in converting a folder of itests to specs tests?

@dsherret
Copy link
Member Author

No, by internal I just meant internal code. This would be a great thing for anyone to contribute! I'd really like to deprecate itest. If anyone works on this I'd recommend doing it a bit at a time so that the PRs are manageable.

@marvinhagemeister marvinhagemeister added the good first issue Good for newcomers label Aug 29, 2024
@MohammadSu2000
Copy link

MohammadSu2000 commented Sep 1, 2024

Can I pick this up?
If it is possible to pick it up, I would like to move the doc_tests.rs first.

@HasanAlrimawi
Copy link
Contributor

I'm deprecating the integration tests of eval_tests.rs in favor of spec tests.

@bartlomieju
Copy link
Member

@MohammadSu2000 @HasanAlrimawi please do!

dsherret added a commit that referenced this issue Sep 3, 2024
This PR serves as a part of #22907 .

---------

Signed-off-by: David Sherret <dsherret@users.noreply.github.com>
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: David Sherret <dsherret@users.noreply.github.com>
@HasanAlrimawi
Copy link
Contributor

I'm deprecating test_itests.rs

@MohammadSu1
Copy link
Contributor

I'm deprecating the worker_tests.rs file

@MohammadSu1
Copy link
Contributor

I'm deprecating the node_compat_tests.rs file

@HasanAlrimawi
Copy link
Contributor

I'm deprecating task_tests.rs

@MohammadSu1
Copy link
Contributor

I'm deprecating the info_tests.rs file

bartlomieju pushed a commit that referenced this issue Sep 11, 2024
@HasanAlrimawi
Copy link
Contributor

I'm deprecating lint_tests.rs

dsherret pushed a commit that referenced this issue Sep 16, 2024
This PR is part of #22907

---------

Signed-off-by: HasanAlrimawi <141642411+HasanAlrimawi@users.noreply.github.com>
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
@MohammadSu1
Copy link
Contributor

I'm deprecating the npm_tests.rs

bartlomieju pushed a commit that referenced this issue Dec 10, 2024
)

This PR progresses #22907 by deprecating the usage of `itest` in
`tests/integration/check_tests.rs`
bartlomieju pushed a commit that referenced this issue Dec 11, 2024
)

This PR progresses #22907 by deprecating the usage of `itest` in
`tests/integration/check_tests.rs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore something that we should get around to eventually good first issue Good for newcomers tests related to tests
Projects
None yet
Development

No branches or pull requests

7 participants