Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FileInfo.path #2313

Merged
merged 2 commits into from
May 16, 2019
Merged

Remove FileInfo.path #2313

merged 2 commits into from
May 16, 2019

Conversation

ry
Copy link
Member

@ry ry commented May 8, 2019

Closes #1770

depends on denoland/std#398 in deno_std
depends on #2361

@ry
Copy link
Member Author

ry commented May 8, 2019

I will need to remove this from deno_std first:

~/src/deno> ./target/debug/deno fmt badly_formatted.js
Compiling https://raw.githubusercontent.com/denoland/deno_std/master/prettier/main.ts
/Users/rld/Library/Caches/deno/deps/https/raw.githubusercontent.com/denoland/deno_std/master/prettier/main.ts:183:38 - error TS2339: Property 'path' does not exist on type 'FileInfo'.

183     const parser = selectParser(file.path);
                                         ~~~~
/Users/rld/Library/Caches/deno/deps/https/raw.githubusercontent.com/denoland/deno_std/master/prettier/main.ts:185:34 - error TS2339: Property 'path' does not exist on type 'FileInfo'.

185       checks.push(checkFile(file.path, parser, prettierOpts));
                                     ~~~~
/Users/rld/Library/Caches/deno/deps/https/raw.githubusercontent.com/denoland/deno_std/master/prettier/main.ts:211:38 - error TS2339: Property 'path' does not exist on type 'FileInfo'.

211     const parser = selectParser(file.path);
                                         ~~~~
/Users/rld/Library/Caches/deno/deps/https/raw.githubusercontent.com/denoland/deno_std/master/prettier/main.ts:213:36 - error TS2339: Property 'path' does not exist on type 'FileInfo'.

213       formats.push(formatFile(file.path, parser, prettierOpts));
                                       ~~~~

cc @kt3k

@ry ry force-pushed the file_info_path branch from 286474a to 1e86a8a Compare May 15, 2019 19:03
@ry ry merged commit e02d8bc into denoland:master May 16, 2019
@ry ry mentioned this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove FileInfo.path
2 participants