Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

walk() should not use deprecated FileInfo.path #398

Merged
merged 2 commits into from
May 14, 2019
Merged

walk() should not use deprecated FileInfo.path #398

merged 2 commits into from
May 14, 2019

Conversation

ry
Copy link
Member

@ry ry commented May 13, 2019 •
edited
Loading

walk() made extensive use of FileInfo.path which will be removed in future versions.

cc @kt3k

Note: this is necessary to bump CI to v0.5 #393

Necessary for denoland/deno#2313 too

@ry ry force-pushed the walk_file_info_path branch from 13cf060 to c97e2fa Compare May 13, 2019 15:17
@ry ry requested a review from piscisaureus May 13, 2019 15:44
@ry ry force-pushed the walk_file_info_path branch from 9c9892b to 109ff9e Compare May 13, 2019 15:46
@ry ry changed the title Walk file info path walk() should not use deprecated FileInfo.path May 13, 2019
This was referenced May 13, 2019
Closed
Merged
@ry
fs: walk() should not use deprecated FileInfo.path
360df28 
The walk() interface is change to return a WalkInfo object which
contains both the resolved filename and FileInfo object from stat.

The followSymlinks feature is disabled for now.
@ry ry force-pushed the walk_file_info_path branch from 109ff9e to 360df28 Compare May 13, 2019 18:08
kt3k
kt3k reviewed May 14, 2019
View reviewed changes
prettier/main.ts Outdated Show resolved Hide resolved
kt3k
kt3k approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

piscisaureus
piscisaureus approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, although it does look like a no-improvement regression as it cant walk symlinks any more.

@ry ry merged commit 07ca4f9 into denoland:master May 14, 2019
ry added a commit to ry/deno that referenced this pull request Oct 9, 2019
@ry
walk() should not use deprecated FileInfo.path (denoland/std#398)
1b359f4 
The walk() interface is change to return a WalkInfo object which
contains both the resolved filename and FileInfo object from stat.

The followSymlinks feature is disabled for now.

Original: denoland/std@07ca4f9
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
@iuioiua
feat: cursor-based pagination for users table (denoland#446)
e27502e 
Closes denoland#398
Towards denoland#414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ry @piscisaureus @kt3k