chore: Deprecate node compat itests #25573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsherret Can you please review this pull request? |
bartlomieju
reviewed
Sep 11, 2024
…ts and node_compat tests
…mmadSu1/my_deno into deprecate_node_compat_tests
|
@bartlomieju Done. |
|
@dsherret Can you please review this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Deprecate node compat itests
This PR is part of solving #22907.
In this PR, The node_compat_tests.rs file was deprecated, and all the tests were moved under specs/node_compat_tests.
Additionally, the related files under testdata/node were removed after ensuring that they weren't related to any other test.