Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate run itests #26444

Merged
merged 12 commits into from
Nov 5, 2024
Merged

Conversation

MohammadSu1
Copy link
Contributor

chore: deprecate run itests
This PR is part of solving #22907.
The run_tests.rs file was deprecated in this PR, and the tests were moved under specs/run.
Additionally, the related files under testdata/run were removed.

@MohammadSu1
Copy link
Contributor Author

@dsherret Could you please review this PR?

@dsherret dsherret self-requested a review October 24, 2024 18:53
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret
Copy link
Member

dsherret commented Nov 4, 2024

I just managed to type the above comment on the review page between my browser freezing lol. Reviewed by looking at a git diff of this PR against main.

Thanks a lot @MohammadSu1! This is a ton of work and is slowly moving the code in a better place.

@dsherret dsherret enabled auto-merge (squash) November 4, 2024 17:13
@dsherret dsherret merged commit 89f0b79 into denoland:main Nov 5, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants