-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port internal TS code to JS #6793
Conversation
Happy to add TSDoc - I agree that gets us 90% of the way there. I'm not going to request that Bartek do that in this PR tho. |
Fixed in #6807 (for |
This reverts commit e3c6b54.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The markdown |
This PR converts our internal runtime code to use pure JS instead of TS. It enables future refactors:
This work has been planned extensively beforehand: See the design doc.
Incremental compile: from 2 min down to 30 seconds
Release binary size: 1mb smaller
Due to removing source maps for internal code. (Measured on mac.)
Code size: ~2700 fewer lines of code
In particular, removes our compile-time TypeScript compiler. This reduces the number of custom TypeScript compilers from 2 to 1.