Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of SWC #220

Closed

Conversation

alshdavid
Copy link

Updated the version of SWC.

Not sure how to test this change, I ran:

cargo build
cargo test

I'm not sure how to consume this from Deno CLI locally for testing

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2024

CLA assistant check
All committers have signed the CLA.

Cargo.toml Outdated
@@ -1,6 +1,6 @@
[package]
name = "deno_ast"
version = "0.34.2"
version = "0.34.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this patch version bump?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, reverted!

@dsherret
Copy link
Member

dsherret commented Mar 13, 2024

Updating swc takes about a days worth of work because we need to test this in all dependent crates and make certain updates. Are there any specific fixes in swc that you need? We'll probalby do an swc upgrade again once swc-project/swc#8736 lands (we do an swc upgrade about once a month)

@alshdavid
Copy link
Author

Updating swc takes about a days worth of work because we need to test this in all dependent crates and make certain updates. Are there any specific fixes in swc that you need? We'll probalby do an swc upgrade again once swc-project/swc#8736 lands (we do an swc upgrade about once a month)

Hey, thanks for reviewing my change. My motivation for bumping swc is that my main project already uses a newer version of swc and consuming deno_ast causes a versioning conflict that Cargo cannot resolve.

That said I have managed to isolate Deno (and its dependencies) from my main application so this is no longer a concern and there is no urgency to merge this PR from my end.

@dsherret dsherret closed this in #225 Apr 2, 2024
@alshdavid alshdavid deleted the alsh/update-swc-version branch April 2, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants