Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/ast): Support abstract auto-accessors #8736

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

dsherret
Copy link
Contributor

Description:

Supports abstract auto-accessors: https://github.com/microsoft/TypeScript/blob/3e91592b06096e1cfdc6eb05a95838831e547e22/tests/baselines/reference/autoAccessorAllowedModifiers.js#L9

BREAKING CHANGE:

Adds a new is_abstract property

Related issue (if exists):

@dsherret dsherret requested a review from a team as a code owner March 12, 2024 15:09
Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: 66e7224

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Mar 13, 2024
@kdy1 kdy1 self-assigned this Mar 13, 2024
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this urgent? I'm asking as this change break Wasm plugins


swc-bump:

  • swc_ecma_ast --breaking

@kdy1 kdy1 changed the title feat: Support abstract auto-accessors feat(es/ast): Support abstract auto-accessors Apr 23, 2024
@kdy1 kdy1 enabled auto-merge (squash) April 23, 2024 23:58
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge April 24, 2024 00:35
@kdy1 kdy1 merged commit 1155ac7 into swc-project:main Apr 24, 2024
148 of 289 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.5.1, v1.5.0 Apr 27, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants