Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation(semver): deprecate rangeMax() and rangeMin() #4561

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Apr 10, 2024

closes #4365

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple of tweaks. Now, LGTM!

@iuioiua iuioiua changed the title deprecation(semver): deprecate rangeMax and rangeMin deprecation(semver): deprecate rangeMax() and rangeMin() Apr 10, 2024
@kt3k kt3k merged commit 6220121 into denoland:main Apr 11, 2024
13 checks passed
iuioiua added a commit that referenced this pull request Apr 11, 2024
iuioiua added a commit that referenced this pull request Apr 11, 2024
* deprecation(semver): deprecate `rangeMax()` and `rangeMin()` (#4561)
To accompany #4569

* Update CONTRIBUTING.md

Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>

* fmt

---------

Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
@kt3k kt3k deleted the deprecate-range-min-max branch May 30, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

semver: deprecate rangeMax and rangeMin
2 participants