Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation(semver): deprecate rangeMax() and rangeMin() #4561

Merged
merged 4 commits into from
Apr 11, 2024
Merged

deprecation(semver): deprecate rangeMax() and rangeMin() #4561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eca9c0f
deprecation(semver): deprecate rangeMax and rangeMin
kt3k Apr 10, 2024
57490b0
add docs
kt3k Apr 10, 2024
0292940
add links
kt3k Apr 10, 2024
65c1b95
tweaks
iuioiua Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions semver/range_max.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ function comparatorMax(comparator: Comparator): SemVer {
}

/**
* @deprecated (will be removed in 1.0.0) Use {@linkcode greaterThanRange} or
* {@linkcode lessThanRange} for comparing ranges and semvers. The maximum
* version of a range is often not well defined, and therefore this API
* shouldn't be used. See
* {@link https://github.com/denoland/deno_std/issues/4365} for details.
*
* The maximum valid SemVer for a given range or INVALID
* @param range The range to calculate the max for
* @returns A valid SemVer or INVALID
Expand Down
6 changes: 6 additions & 0 deletions semver/range_min.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ function comparatorMin(comparator: Comparator): SemVer {
}

/**
* @deprecated (will be removed in 1.0.0) Use {@linkcode greaterThanRange} or
* {@linkcode lessThanRange} for comparing ranges and semvers. The minimum
* version of a range is often not well defined, and therefore this API
* shouldn't be used. See
* {@link https://github.com/denoland/deno_std/issues/4365} for details.
*
* The minimum valid SemVer for a given range or INVALID
* @param range The range to calculate the min for
* @returns A valid SemVer or INVALID
Expand Down