-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump deno to v0.10.0 #524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
approved these changes
Jun 26, 2019
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
…ade` (denoland#549) First contribution towards improving e2e tests in denoland#524 --------- Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
Adds coverage as part of denoland#524 The page can throw a general error, which would happen if the notification was found but then deleting the key in KV failed. I can't think of a great way to exercise this code path unless we mock `getAndDeleteNotification` for one test and have it throw? --------- Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
Adding more e2e coverage for denoland#524 --------- Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
…board`, `GET /dashboard/stats` and `GET /dashboard/users` (denoland#557) Adding more coverage on behalf of denoland#524 --------- Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
…te` and `POST /api/items/:id/vote` (denoland#565) Adds coverage on behalf of denoland#524
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
) working towards denoland#524. adds a couple custom assertion fns to have a predictable set to work with. --------- Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge on approval