Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump to v0.13.0 #552

Closed
wants to merge 1 commit into from
Closed

ci: bump to v0.13.0 #552

wants to merge 1 commit into from

Conversation

ry
Copy link
Member

@ry ry commented Aug 5, 2019

merge on approval

@ry ry requested a review from piscisaureus August 5, 2019 16:20
@ry
Copy link
Member Author

ry commented Aug 5, 2019

Windows is failing with

[command]"C:\Program Files\Git\bin\bash.exe" --noprofile --norc /d/a/_temp/db24355d-291c-4c00-b0b8-c1fe00084c1f.sh
Compile file:///D:/a/1/s/format.ts
Compile file:///D:/a/1/s/prettier/main.ts
a\1\s\colors\mod.ts.js ... Not formatted
a\1\s\format.ts.js ... Not formatted
a\1\s\fs\path\interface.ts.js ... Not formatted
a\1\s\fs\glob.ts.js ... Not formatted
a\1\s\fs\path\mod.ts.js ... Not formatted
a\1\s\prettier\prettier.ts.js ... Not formatted
a\1\s\prettier\util.ts.js ... Not formatted
a\1\s\flags\mod.ts.js ... Not formatted
a\1\s\fs\path\constants.ts.js ... Not formatted
a\1\s\fs\walk.ts.js ... Not formatted
a\1\s\fs\globrex.ts.js ... Not formatted
a\1\s\fs\path\utils.ts.js ... Not formatted
a\1\s\fs\path\posix.ts.js ... Not formatted
a\1\s\testing\pretty.ts.js ... Not formatted
a\1\s\fs\path\win32.ts.js ... Not formatted
a\1\s\prettier\main.ts.js ... Not formatted
a\1\s\testing\asserts.ts.js ... Not formatted
a\1\s\testing\diff.ts.js ... Not formatted
a\1\s\testing\format.ts.js ... Not formatted
Some files are not formatted

not sure why (cc @kt3k)

Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, go ahead and land when you figure out this formatting issue.

@kt3k
Copy link
Member

kt3k commented Aug 6, 2019

@ry

a\1\s\colors\mod.ts.js ... Not formatted
a\1\s\format.ts.js ... Not formatted
a\1\s\fs\path\interface.ts.js ... Not formatted

Filenames look strange to me. Are those files transpiled from typescript? They look something which shouldn't exist there..

(Is there any possibility that v0.13.0 includes such change?)

@bartlomieju
Copy link
Member

Filenames look strange to me. Are those files transpiled from typescript? They look something which shouldn't exist there..

They are, however they should only be placed in DENO_DIR, not in the same directory as project code. I'm debugging

@bartlomieju
Copy link
Member

The problem seems to be with $DENO_DIR since it's not defined it's falling back to each system specific cache directory. Somehow on Windows it ends up being a directory in current directory:

drwxr-xr-x 1 VssAdministrator 197121    0 Aug 10 10:26 a
drwxr-xr-x 1 VssAdministrator 197121    0 Aug 10 10:24 archive
-rw-r--r-- 1 VssAdministrator 197121  477 Aug 10 10:24 azure-pipelines.yml

I'm working on updating CI scripts to set $DENO_DIR to location outside of project directory in pipeline

@bartlomieju
Copy link
Member

I've got the problem...
https://github.com/denoland/deno/blob/286ee1d8b68b54d39e698f3b78e3ce9e257fa674/cli/disk_cache.rs#L21-L24

I'm gonna start fixing it now, @ry would you be able to cut v0.14.1 release so we can release standard lib?

@ry
Copy link
Member Author

ry commented Aug 14, 2019

handled in #556

@ry ry closed this Aug 14, 2019
@ry ry deleted the v0.13 branch August 14, 2019 19:14
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
Adds coverage as part of denoland#524 

The page can throw a general error, which would happen if the
notification was found but then deleting the key in KV failed. I can't
think of a great way to exercise this code path unless we mock
`getAndDeleteNotification` for one test and have it throw?

---------

Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants