-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump to v0.13.0 #552
ci: bump to v0.13.0 #552
Conversation
Windows is failing with
not sure why (cc @kt3k) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, go ahead and land when you figure out this formatting issue.
Filenames look strange to me. Are those files transpiled from typescript? They look something which shouldn't exist there.. (Is there any possibility that v0.13.0 includes such change?) |
They are, however they should only be placed in |
The problem seems to be with
I'm working on updating CI scripts to set |
I've got the problem... I'm gonna start fixing it now, @ry would you be able to cut v0.14.1 release so we can release standard lib? |
handled in #556 |
Adds coverage as part of denoland#524 The page can throw a general error, which would happen if the notification was found but then deleting the key in KV failed. I can't think of a great way to exercise this code path unless we mock `getAndDeleteNotification` for one test and have it throw? --------- Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
merge on approval