Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release expect@1.0.0 #5455

Merged
merged 2 commits into from
Jul 22, 2024
Merged

chore: release expect@1.0.0 #5455

merged 2 commits into from
Jul 22, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 16, 2024

To be merged July 22

The latest API docs: https://jsr.io/@std/expect@1.0.0-rc.3/doc

Closes #5014

@kt3k kt3k requested a review from satyarohith July 16, 2024 12:25
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

great to have 100% score
CleanShot 2024-07-16 at 20 31 03@2x

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (c3ccd67) to head (9820a60).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5455   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         463      463           
  Lines       37660    37660           
  Branches     5558     5558           
=======================================
  Hits        36267    36267           
  Misses       1351     1351           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Contributor

iuioiua commented Jul 21, 2024

My main concern with this package is the documentation. The main documentation details the API, but doesn't link to the appropriate symbols. When one does find the documentation for a given symbol (e.g. expect.toBeCalledWith()), there's no example. We can either write this documentation ourselves or link to Jest's.

@kt3k kt3k merged commit b6b0d68 into denoland:main Jul 22, 2024
17 checks passed
@kt3k kt3k deleted the expect-1 branch July 22, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stabilize @std/expect
3 participants