Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(expect): link to matcher docs #5502

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 22, 2024

related #5455

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (abdecb3) to head (6c13733).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5502   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         464      465    +1     
  Lines       37679    37705   +26     
  Branches     5561     5561           
=======================================
+ Hits        36286    36312   +26     
  Misses       1351     1351           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

expect/mod.ts Outdated
* - `toThrow`
* - `toHaveProperty`
* - `toHaveLength`
* - [`toBe`](./doc/~/Expected.toBe)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* - [`toBe`](./doc/~/Expected.toBe)
* - {@linkcode Expected.toBe}

or

 *   - {@linkcode Expected.toBe | toBe}

@kt3k kt3k merged commit a8a637f into denoland:main Jul 22, 2024
16 checks passed
@kt3k kt3k deleted the docs-expect-link-to-matchers branch July 22, 2024 06:09
@iuioiua
Copy link
Contributor

iuioiua commented Jul 23, 2024

Actually, we still don't document how use the API (e.g. expect.toBe). We should do that before publishing expect@1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants