-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SeanC/APPEALS-5034 Decided non-comp issues are not getting closed as …
…decided (#20126) * added basic code to meet ac * updated code in decsion reveiw task * updated code to set the completed_by as well * started refactoring handle_issues_with_no_decision_date! * refactored function to reduce cyclomatic complexity * fixed a code climate issue * attempting to fix a code climate issue * moved handle_issues_with_no_decision_date! to decision_review to fix code climate issue * Empty-Commit * put function back * fixed the failing tests in decision_review_task_spec * Added _current_user to complete_with_payload in business_line_task * fixed a test in board_grant_effectuation_task_spec * created a new def in request_issues for active or decided * added the new def to the serializer * changed the name of activeRequestIssues to activeOrDecidedRequestIssues * updated business_line_task to set completed_by for board grants * added basic code to meet ac * updated code in decsion reveiw task * updated code to set the completed_by as well * started refactoring handle_issues_with_no_decision_date! * refactored function to reduce cyclomatic complexity * fixed a code climate issue * attempting to fix a code climate issue * moved handle_issues_with_no_decision_date! to decision_review to fix code climate issue * Empty-Commit * put function back * fixed the failing tests in decision_review_task_spec * Added _current_user to complete_with_payload in business_line_task * fixed a test in board_grant_effectuation_task_spec * created a new def in request_issues for active or decided * added the new def to the serializer * changed the name of activeRequestIssues to activeOrDecidedRequestIssues * updated business_line_task to set completed_by for board grants * addressing first comment from review * addressed the second comment of review
- Loading branch information
Showing
13 changed files
with
49 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters