-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SeanC/APPEALS-5034 Decided non-comp issues are not getting closed as decided #20126
Conversation
Code Climate has analyzed commit 48f7121 and detected 0 issues on this pull request. View more on Code Climate. |
…code climate issue
…fairs/caseflow into SeanC/APPEALS-5034
…code climate issue
…-veterans-affairs/caseflow into SeanC/APPEALS-5034
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I only noticed a couple of things. I also think we need a couple of new test expectations for future regression testing to verify that the completed by field is being successfully updated with the user and also that the request issues are correctly being closed out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Good job!
…-of-veterans-affairs/caseflow into SeanC/APPEALS-5034
Resolves Decided non-comp issues are not getting closed as decided
Jira Description
For SC's (supplemental claims) and HLR's (higher level reviews), if the business line is not compensation or pension, the decision reviews go to what we call the "non-comp queue", a lightweight version of queue that allows users to add decisions to request issues.
When users are adding decisions, the decision issues are getting added, but the request issues are not being closed as "decided". This allows users to go back in and edit later, and do another action such as withdraw the issue.
See DecisionReviewTask.complete_with_payload! where decision issues are getting created, the task is getting closed, but the request issues are not getting closed. RequestIssue.close_decided_issue! should be called somewhere.
Description of Changes
For SC's (supplemental claims) and HLR's (higher level reviews), that are in the non-comp queue, when a user adds decision to a decision issue. The request issues are now being closed as "decided" and the completed_by_id is set to the user_id of the user that added the decision.
Acceptance Criteria
Testing Plan
task = Task.find(<task_id>)
User.find_by(css_id: <user's css_id>)
task.appeal.request_issues.first
closed_status: "decided"
Best practices
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?